Skip to content

fix(ThIcon): Replace ThIcon with RhUiGripHorizontalFillIcon#12477

Open
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-th-icon-with-rh-ui-grip-horizontal-fill
Open

fix(ThIcon): Replace ThIcon with RhUiGripHorizontalFillIcon#12477
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:cursor/replace-th-icon-with-rh-ui-grip-horizontal-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 16, 2026

Copy link
Copy Markdown
Member

Part of #12401. Breaking into separate PRs so it is easier to review.

This is the closest icon I could find, but it's a little off from the prior pattern (two rows of icons vs. three). We may want to wait on this and get a new icon made.

Made with Cursor

Summary by CodeRabbit

Summary by CodeRabbit

  • Style

    • Updated the “Applications” menu toggle icon across Compass, Custom Menus, Masthead, and Nav demos, replacing the previous icon with RhUiThumbnailViewSmallFillIcon in both expanded and collapsed/tooltip states.
  • Documentation

    • Refreshed the corresponding demo documentation to use the updated icon import, matching the visual changes in the examples.

@rebeccaalpert rebeccaalpert marked this pull request as draft June 16, 2026 20:29
@patternfly-build

patternfly-build commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1a51e142-3490-4fca-870a-b811976a19ea

📥 Commits

Reviewing files that changed from the base of the PR and between cdab88e and b949615.

📒 Files selected for processing (9)
  • packages/react-core/src/demos/Compass/Compass.md
  • packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx
  • packages/react-core/src/demos/CustomMenus/ApplicationLauncher.md
  • packages/react-core/src/demos/CustomMenus/CustomMenus.md
  • packages/react-core/src/demos/CustomMenus/examples/ApplicationLauncherDemo.tsx
  • packages/react-core/src/demos/Masthead.md
  • packages/react-core/src/demos/Nav.md
  • packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx
  • packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx
✅ Files skipped from review due to trivial changes (6)
  • packages/react-core/src/demos/CustomMenus/CustomMenus.md
  • packages/react-core/src/demos/Masthead.md
  • packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx
  • packages/react-core/src/demos/CustomMenus/examples/ApplicationLauncherDemo.tsx
  • packages/react-core/src/demos/Compass/Compass.md
  • packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/react-core/src/demos/CustomMenus/ApplicationLauncher.md

Walkthrough

Across four demo TSX components and five companion Markdown documentation files, the ThIcon import is replaced with RhUiThumbnailViewSmallFillIcon from @patternfly/react-icons. The new icon is applied to MenuToggle icon props in the Applications/toolbar toggle controls, covering both expanded and collapsed (tooltip-wrapped) rendering branches.

Changes

Icon Substitution in Demo Components and Docs

Layer / File(s) Summary
Icon swap in demo TSX components
packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx, packages/react-core/src/demos/CustomMenus/examples/ApplicationLauncherDemo.tsx, packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx, packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx
Adds RhUiThumbnailViewSmallFillIcon import and replaces ThIcon in MenuToggle icon props; both expanded and tooltip-wrapped collapsed branches are updated in docked demos.
Icon import update in demo markdown files
packages/react-core/src/demos/Compass/Compass.md, packages/react-core/src/demos/CustomMenus/ApplicationLauncher.md, packages/react-core/src/demos/CustomMenus/CustomMenus.md, packages/react-core/src/demos/Masthead.md, packages/react-core/src/demos/Nav.md
Icon import lines updated to reference RhUiThumbnailViewSmallFillIcon instead of ThIcon.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Needs design review

Suggested reviewers

  • nicolethoen
  • bekah-stephens
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to replace ThIcon with RhUiGripHorizontalFillIcon, but the actual implementation replaces it with RhUiThumbnailViewSmallFillIcon, creating a mismatch between the title and changeset. Update the PR title to 'fix(ThIcon): Replace ThIcon with RhUiThumbnailViewSmallFillIcon' to accurately reflect the actual icon being used in the implementation.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-th-icon-with-rh-ui-grip-horizontal-fill branch from c2d1f09 to cdab88e Compare June 18, 2026 13:57
…rizontalFillIcon

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants