Skip to content

fix(CodeBranchIcon): Replace CodeBranchIcon with RhUiBranchIcon #12489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(CodeBranchIcon): Replace CodeBranchIcon with RhUiBranchIcon #12489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d90a29
fix(CodeBranchIcon): Replace CodeBranchIcon with RhUiBranchIcon
rebeccaalpert Jun 16, 2026
b017cc5
fix(CodeBranchIcon): Use RhUiBranchFillIcon instead of RhUiBranchIcon
rebeccaalpert Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/DataList/examples/DataList.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ propComponents:
---

import { Fragment, useState } from 'react';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon';
import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon';
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
Expand Down
8 changes: 4 additions & 4 deletions packages/react-core/src/components/DataList/examples/DataListExpandable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
MenuToggleElement
} from '@patternfly/react-core';
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';

export const DataListExpandable: React.FunctionComponent = () => {
const [isOpen1, setIsOpen1] = useState(false);
Expand Down Expand Up @@ -66,7 +66,7 @@ export const DataListExpandable: React.FunctionComponent = () => {
<DataListItemCells
dataListCells={[
<DataListCell isIcon key="icon">
<CodeBranchIcon />
<RhUiBranchFillIcon />
</DataListCell>,
<DataListCell key="primary content">
<div id="ex-item1">Primary content</div>
Expand Down Expand Up @@ -137,7 +137,7 @@ export const DataListExpandable: React.FunctionComponent = () => {
<DataListItemCells
dataListCells={[
<DataListCell isIcon key="icon">
<CodeBranchIcon />
<RhUiBranchFillIcon />
</DataListCell>,
<DataListCell key="secondary content">
<div id="ex-item2">Secondary content</div>
Expand Down Expand Up @@ -207,7 +207,7 @@ export const DataListExpandable: React.FunctionComponent = () => {
<DataListItemCells
dataListCells={[
<DataListCell isIcon key="icon">
<CodeBranchIcon />
<RhUiBranchFillIcon />
</DataListCell>,
<DataListCell key="tertiary content">
<div id="ex-item3">Tertiary content</div>
Expand Down
8 changes: 4 additions & 4 deletions packages/react-core/src/components/DataList/examples/DataListMixedExpandable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
MenuToggleElement
} from '@patternfly/react-core';
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';

export const DataListMixedExpandable: React.FunctionComponent = () => {
const [isOpen1, setIsOpen1] = useState(false);
Expand Down Expand Up @@ -68,7 +68,7 @@ export const DataListMixedExpandable: React.FunctionComponent = () => {
<DataListItemCells
dataListCells={[
<DataListCell isIcon key="icon">
<CodeBranchIcon />
<RhUiBranchFillIcon />
</DataListCell>,
<DataListCell key="primary content">
<div id="m-ex-item1">Primary content</div>
Expand Down Expand Up @@ -141,7 +141,7 @@ export const DataListMixedExpandable: React.FunctionComponent = () => {
<DataListItemCells
dataListCells={[
<DataListCell isIcon key="icon">
<CodeBranchIcon />
<RhUiBranchFillIcon />
</DataListCell>,
<DataListCell key="secondary content">
<div id="m-ex-item2">Secondary content</div>
Expand Down Expand Up @@ -201,7 +201,7 @@ export const DataListMixedExpandable: React.FunctionComponent = () => {
<DataListItemCells
dataListCells={[
<DataListCell isIcon key="icon">
<CodeBranchIcon />
<RhUiBranchFillIcon />
</DataListCell>,
<DataListCell key="tertiary content">
<div id="m-ex-item3">Tertiary content</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Menu/examples/Menu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ouia: true
import { Fragment, createRef, useEffect, useRef, useState } from 'react';
import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon';
import RhUiClipboardFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-clipboard-fill-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import LayerGroupIcon from '@patternfly/react-icons/dist/esm/icons/layer-group-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import RhUiTableIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-table-icon';
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Menu/examples/MenuWithActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { useState } from 'react';
import { Menu, MenuContent, MenuGroup, MenuList, MenuItem, MenuItemAction } from '@patternfly/react-core';
import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon';
import RhUiClipboardFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-clipboard-fill-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon';

export const MenuWithActions: React.FunctionComponent = () => {
Expand Down Expand Up @@ -31,7 +31,7 @@ export const MenuWithActions: React.FunctionComponent = () => {
isSelected={selectedItems.indexOf(0) !== -1}
actions={
<MenuItemAction
icon={<CodeBranchIcon />}
icon={<RhUiBranchFillIcon />}
actionId="code"
// eslint-disable-next-line no-console
onClick={() => console.log('clicked on code icon')}
Expand Down
8 changes: 4 additions & 4 deletions packages/react-core/src/components/Menu/examples/MenuWithDescription.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useState } from 'react';
import { Menu, MenuContent, MenuList, MenuItem } from '@patternfly/react-core';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';

export const MenuWithDescription: React.FunctionComponent = () => {
const [activeItem, setActiveItem] = useState(0);
Expand All @@ -15,14 +15,14 @@ export const MenuWithDescription: React.FunctionComponent = () => {
<Menu onSelect={onSelect} activeItemId={activeItem}>
<MenuContent>
<MenuList>
<MenuItem icon={<CodeBranchIcon />} description="Description" itemId={0}>
<MenuItem icon={<RhUiBranchFillIcon />} description="Description" itemId={0}>
Action 1
</MenuItem>
<MenuItem isDisabled icon={<CodeBranchIcon />} description="Description" itemId={1}>
<MenuItem isDisabled icon={<RhUiBranchFillIcon />} description="Description" itemId={1}>
Action 2 disabled
</MenuItem>
<MenuItem
icon={<CodeBranchIcon />}
icon={<RhUiBranchFillIcon />}
description="Nunc non ornare ex, et pretium dui. Duis nec augue at urna elementum blandit tincidunt eget metus. Aenean sed metus id urna dignissim interdum. Aenean vel nisl vitae arcu vehicula pulvinar eget nec turpis. Cras sit amet est est."
itemId={2}
>
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Menu/examples/MenuWithDrilldown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useState } from 'react';
import { Menu, MenuContent, MenuList, MenuItem, Divider, DrilldownMenu } from '@patternfly/react-core';
import StorageDomainIcon from '@patternfly/react-icons/dist/esm/icons/storage-domain-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import LayerGroupIcon from '@patternfly/react-icons/dist/esm/icons/layer-group-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';

Expand Down Expand Up @@ -161,7 +161,7 @@ export const MenuWithDrilldown: React.FunctionComponent = () => {
Add storage
</MenuItem>
<Divider component="li" />
<MenuItem icon={<CodeBranchIcon />} itemId="git">
<MenuItem icon={<RhUiBranchFillIcon />} itemId="git">
From git
</MenuItem>
<MenuItem icon={<LayerGroupIcon />} itemId="container">
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Menu/examples/MenuWithDrilldownBreadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
MenuToggleElement
} from '@patternfly/react-core';
import StorageDomainIcon from '@patternfly/react-icons/dist/esm/icons/storage-domain-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import LayerGroupIcon from '@patternfly/react-icons/dist/esm/icons/layer-group-icon';
import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
Expand Down Expand Up @@ -440,7 +440,7 @@ export const MenuWithDrilldownBreadcrumbs: React.FunctionComponent = () => {
onClick={() => setBreadcrumb(addStorageBreadcrumb)}
drilldownMenu={
<DrilldownMenu id="breadcrumbs-drilldownMenuStorage">
<MenuItem icon={<CodeBranchIcon />} itemId="git">
<MenuItem icon={<RhUiBranchFillIcon />} itemId="git">
From git
</MenuItem>
<MenuItem icon={<LayerGroupIcon />} itemId="container">
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Menu/examples/MenuWithDrilldownInitialState.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useState } from 'react';
import { Menu, MenuContent, MenuList, MenuItem, Divider, DrilldownMenu } from '@patternfly/react-core';
import StorageDomainIcon from '@patternfly/react-icons/dist/esm/icons/storage-domain-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import LayerGroupIcon from '@patternfly/react-icons/dist/esm/icons/layer-group-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';

Expand Down Expand Up @@ -164,7 +164,7 @@ export const MenuDrilldownInitialState: React.FunctionComponent = () => {
Add storage
</MenuItem>
<Divider component="li" />
<MenuItem icon={<CodeBranchIcon />} itemId="git">
<MenuItem icon={<RhUiBranchFillIcon />} itemId="git">
From git
</MenuItem>
<MenuItem icon={<LayerGroupIcon />} itemId="container">
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Menu/examples/MenuWithDrilldownSubmenuFunctions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useState } from 'react';
import { Menu, MenuContent, MenuList, MenuItem, Divider, DrilldownMenu } from '@patternfly/react-core';
import StorageDomainIcon from '@patternfly/react-icons/dist/esm/icons/storage-domain-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import LayerGroupIcon from '@patternfly/react-icons/dist/esm/icons/layer-group-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';

Expand Down Expand Up @@ -161,7 +161,7 @@ export const MenuWithDrilldownSubmenuFunctions: React.FunctionComponent = () =>
Add storage
</MenuItem>
<Divider component="li" />
<MenuItem icon={<CodeBranchIcon />} itemId="git">
<MenuItem icon={<RhUiBranchFillIcon />} itemId="git">
From git
</MenuItem>
<MenuItem icon={<LayerGroupIcon />} itemId="container">
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Menu/examples/MenuWithIcons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useState } from 'react';
import { Menu, MenuContent, MenuList, MenuItem } from '@patternfly/react-core';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import LayerGroupIcon from '@patternfly/react-icons/dist/esm/icons/layer-group-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';

Expand All @@ -17,7 +17,7 @@ export const MenuWithIcons: React.FunctionComponent = () => {
<Menu onSelect={onSelect} activeItemId={activeItem}>
<MenuContent>
<MenuList>
<MenuItem icon={<CodeBranchIcon />} itemId={0}>
<MenuItem icon={<RhUiBranchFillIcon />} itemId={0}>
From git
</MenuItem>
<MenuItem icon={<LayerGroupIcon />} itemId={1}>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/demos/CustomMenus/CustomMenus.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { cloneElement, Fragment, useEffect, useRef, useState } from 'react';

import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon';
import StorageDomainIcon from '@patternfly/react-icons/dist/esm/icons/storage-domain-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import LayerGroupIcon from '@patternfly/react-icons/dist/esm/icons/layer-group-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon';
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { useRef, useState } from 'react';
import { MenuToggle, MenuItemAction, Select, SelectGroup, SelectList, SelectOption } from '@patternfly/react-core';
import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon';
import RhUiClipboardFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-clipboard-fill-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon';

export const ActionsMenuDemo: React.FunctionComponent = () => {
Expand Down Expand Up @@ -46,7 +46,7 @@ export const ActionsMenuDemo: React.FunctionComponent = () => {
isSelected={selectedItems.includes(0)}
actions={
<MenuItemAction
icon={<CodeBranchIcon />}
icon={<RhUiBranchFillIcon />}
actionId="code"
// eslint-disable-next-line no-console
onClick={() => console.log('clicked on code icon')}
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/demos/CustomMenus/examples/DrilldownMenuDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
MenuContainer
} from '@patternfly/react-core';
import StorageDomainIcon from '@patternfly/react-icons/dist/esm/icons/storage-domain-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import LayerGroupIcon from '@patternfly/react-icons/dist/esm/icons/layer-group-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';

Expand Down Expand Up @@ -191,7 +191,7 @@ export const DrilldownMenuDemo: React.FunctionComponent = () => {
Add storage
</MenuItem>
<Divider component="li" />
<MenuItem icon={<CodeBranchIcon />} itemId="git">
<MenuItem icon={<RhUiBranchFillIcon />} itemId="git">
From Git
</MenuItem>
<MenuItem icon={<LayerGroupIcon />} itemId="container">
Expand Down
10 changes: 5 additions & 5 deletions packages/react-core/src/demos/DataList/examples/DataListBasic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ import {
import RhUiEllipsisVerticalFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-ellipsis-vertical-fill-icon';
import { DashboardWrapper } from '@patternfly/react-core/dist/js/demos/DashboardWrapper';

import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiCodeIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-code-icon';
import RhUiBranchFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-branch-fill-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import RhUiWarningFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-warning-fill-icon';
import RhUiCheckCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-check-circle-fill-icon';
Expand Down Expand Up @@ -104,7 +104,7 @@ export const DataListBasic: React.FunctionComponent = () => {
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<Icon>
<CodeBranchIcon />
<RhUiBranchFillIcon />
</Icon>
10 <span className="pf-v6-screen-reader">Branches</span>
</FlexItem>
Expand Down Expand Up @@ -155,7 +155,7 @@ export const DataListBasic: React.FunctionComponent = () => {
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<Icon>
<CodeBranchIcon />
<RhUiBranchFillIcon />
</Icon>
5 <span className="pf-v6-screen-reader">Branches</span>
</FlexItem>
Expand Down Expand Up @@ -253,7 +253,7 @@ export const DataListBasic: React.FunctionComponent = () => {
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<Icon>
<CodeBranchIcon />
<RhUiBranchFillIcon />
</Icon>
10
<span className="pf-v6-screen-reader">Branches</span>
Expand Down Expand Up @@ -305,7 +305,7 @@ export const DataListBasic: React.FunctionComponent = () => {
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<Icon>
<CodeBranchIcon />
<RhUiBranchFillIcon />
</Icon>
5 <span className="pf-v6-screen-reader">Branches</span>
</FlexItem>
Expand Down
Loading
Loading