fix(AngleDoubleRightIcon): Replace AngleDoubleRightIcon with RhMicronsDoubleCaretRightIcon#12493
Open
rebeccaalpert wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (19)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (13)
🚧 Files skipped from review as they are similar to previous changes (5)
Walkthrough
ChangesIcon Swap: AngleDoubleRightIcon → RhMicronsDoubleCaretRightIcon
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-react-pr-12493.surge.sh A11y report: https://pf-react-pr-12493-a11y.surge.sh |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/react-drag-drop/src/components/DragDrop/examples/DragDropContainerDualListSelector.tsx (1)
147-174: ⚡ Quick winUse the
iconprop pattern for consistency with other DualListSelector examples.The controls in this file render icons as child elements, but all other DualListSelector example files in this cohort (and the standard
DualListSelectorControlAPI) use theiconprop pattern. This inconsistency should be unified for clarity and maintainability.♻️ Proposed refactor to use icon prop pattern
<DualListSelectorControlsWrapper aria-label="Selector controls"> <DualListSelectorControl isDisabled={!availableOptions.some((option) => option.props.isSelected)} onClick={() => moveSelected(true)} aria-label="Add selected" + icon={<AngleRightIcon />} - > - <AngleRightIcon /> - </DualListSelectorControl> + /> <DualListSelectorControl isDisabled={availableOptions.length === 0} onClick={() => moveAll(true)} aria-label="Add all" + icon={<RhMicronsDoubleCaretRightIcon />} - > - <RhMicronsDoubleCaretRightIcon /> - </DualListSelectorControl> + /> <DualListSelectorControl isDisabled={chosenOptions.length === 0} onClick={() => moveAll(false)} aria-label="Remove all" + icon={<RhMicronsDoubleCaretLeftIcon />} - > - <RhMicronsDoubleCaretLeftIcon /> - </DualListSelectorControl> + /> <DualListSelectorControl onClick={() => moveSelected(false)} isDisabled={!chosenOptions.some((option) => option.props.isSelected)} aria-label="Remove selected" + icon={<AngleLeftIcon />} - > - <AngleLeftIcon /> - </DualListSelectorControl> + /> </DualListSelectorControlsWrapper>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/react-drag-drop/src/components/DragDrop/examples/DragDropContainerDualListSelector.tsx` around lines 147 - 174, The DualListSelectorControl components are currently rendering icons as child elements (AngleRightIcon, RhMicronsDoubleCaretRightIcon, RhMicronsDoubleCaretLeftIcon, and AngleLeftIcon), but they should use the icon prop pattern for consistency with other DualListSelector examples. Remove the icon elements from inside the DualListSelectorControl components and instead pass each icon as an icon prop to the respective DualListSelectorControl element.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@packages/react-drag-drop/src/components/DragDrop/examples/DragDropContainerDualListSelector.tsx`:
- Around line 147-174: The DualListSelectorControl components are currently
rendering icons as child elements (AngleRightIcon,
RhMicronsDoubleCaretRightIcon, RhMicronsDoubleCaretLeftIcon, and AngleLeftIcon),
but they should use the icon prop pattern for consistency with other
DualListSelector examples. Remove the icon elements from inside the
DualListSelectorControl components and instead pass each icon as an icon prop to
the respective DualListSelectorControl element.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5a47a212-fd49-466f-9823-9322f267535e
⛔ Files ignored due to path filters (3)
packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationNavigation.test.tsx.snapis excluded by!**/*.snap,!**/generated/**packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snapis excluded by!**/*.snappackages/react-core/src/deprecated/components/DualListSelector/__tests__/__snapshots__/DualListSelector.test.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (19)
packages/react-core/src/components/DualListSelector/examples/DualListSelector.mdpackages/react-core/src/components/DualListSelector/examples/DualListSelectorBasic.tsxpackages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicSearch.tsxpackages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicTooltips.tsxpackages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsxpackages/react-core/src/components/DualListSelector/examples/DualListSelectorTree.tsxpackages/react-core/src/components/Pagination/PaginationNavigation.tsxpackages/react-core/src/deprecated/components/DualListSelector/DualListSelector.tsxpackages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.mdpackages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsxpackages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposableDragDrop.tsxpackages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposableTree.tsxpackages/react-drag-drop/src/components/DragDrop/examples/DragDrop.mdpackages/react-drag-drop/src/components/DragDrop/examples/DragDropContainerDualListSelector.tsxpackages/react-drag-drop/src/components/DragDrop/examples/DragDropDemos.mdpackages/react-drag-drop/src/components/DragDrop/examples/DualListSelectorDraggable.tsxpackages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorBasicDemo.tsxpackages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorTreeDemo.tsxpackages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorWithActionsDemo.tsx
💤 Files with no reviewable changes (1)
- packages/react-drag-drop/src/components/DragDrop/examples/DragDrop.md
…sDoubleCaretRightIcon Co-authored-by: Cursor <cursoragent@cursor.com>
rebeccaalpert
force-pushed
the
cursor/replace-angle-double-right-icon-with-rh-microns-double-caret-right
branch
from
9907d0d to
d489970
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Part of #12402. Breaking into separate PRs so it is easier to review.
Additional issues:
Summary by CodeRabbit