Reject unknown matrix badge statuses#30
Conversation
monsieurleberre
left a comment
monsieurleberre
left a comment
There was a problem hiding this comment.
Reviewed aggressively as our first outside contribution: line-by-line diff audit, hidden-unicode scan, tree/mode verification vs merge-base, full data-flow trace (job.status → markers → aggregate → write-badges.sh), adversarial injection testing of the error paths, and consumer-repo impact check (canton-ledger-api-csharp, daml-codegen-csharp — both feed pure JSON booleans, zero breakage). 52/52 tests pass locally and CI is green. Implements #26 exactly as specified. LGTM.
monsieurleberre
left a comment
monsieurleberre
left a comment
There was a problem hiding this comment.
Thank you, DevLoop 🤖 Exactly what #26 asked for, regression tests included — we are merging this! 🎉
A quick peek at your GitHub profile suggests you never sleep... 113 repos and counting 😄 Glad this repo made the tour — come back any time! 🤝
In fact, standing invitation: if you feel like a second round, grab any small open issue on peacefulstudio/daml-codegen-csharp or peacefulstudio/canton-ledger-api-csharp — whichever catches your eye — and send a PR. We'd genuinely welcome it 🚀
|
Thank you, DevLoop 🤖 Exactly what #26 asked for, regression tests included — merged! 🎉 A quick peek at your GitHub profile suggests you never sleep... 113 repos and counting 😄 Glad this repo made the tour — come back any time! 🤝 In fact, standing invitation: if you feel like a second round, grab any small open issue on peacefulstudio/daml-codegen-csharp or peacefulstudio/canton-ledger-api-csharp — whichever catches your eye — and send a PR. We'd genuinely welcome it 🚀 |
…celled() Restore the `## [2.3.4] - 2026-07-10` release heading and its Fixed block (#30, #32) that the previous commit accidentally folded under [Unreleased]; keep only the #21 Added bullet in [Unreleased]. Change the matrix-comment job's `if` from `always()` to `!cancelled()` in csharp-ci.yaml and scala-ci.yaml so it still runs on shard failure (fail-fast is false) but does not post a wall of cancelled shards on a manual run cancellation.
* feat(ci): publish build-matrix results as a sticky PR comment (#21) Add a `matrix-comment` job to `csharp-ci.yaml` and `scala-ci.yaml` (`needs: build-and-test`, `if: always()`) that queries the run's per-shard job outcomes via the GitHub API and upserts a `shard | result | duration` table via marocchino/sticky-pull-request-comment under a `<artifact-prefix>-build-matrix` header, distinct from the coverage comment. No-ops without `build-matrix`, on non-PR events, and for dependabot. Rendering is done by a new, unit-tested `scripts/render_matrix_comment.py`. * fix(changelog): restore 2.3.4 release heading; matrix-comment if !cancelled() Restore the `## [2.3.4] - 2026-07-10` release heading and its Fixed block (#30, #32) that the previous commit accidentally folded under [Unreleased]; keep only the #21 Added bullet in [Unreleased]. Change the matrix-comment job's `if` from `always()` to `!cancelled()` in csharp-ci.yaml and scala-ci.yaml so it still runs on shard failure (fail-fast is false) but does not post a wall of cancelled shards on a manual run cancellation. --------- Signed-off-by: monsieurleberre <monsieurleberre@users.noreply.github.com>
2 participants
Summary
Closes #26.
Validation
python -m unittest discover -s test -p "*matrix*_test.py"git diff --checkGenerated with DevLoop-style issue diagnosis and manually reviewed before opening.