fix: honor nested Python roots and scan exclusions#660
Open
GuusDeKroon12 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Python coverage correlation assumed imports mapped directly beneath the scan root. Projects with a nested source root such as
backend/apptherefore reported covered modules as untested. Dynamic test loaders usingimportlib.util.spec_from_file_locationorrunpy.run_pathwere also missed. Separately, external-tool exclusions could remain relative, allowing Bandit to scan excluded vendor/reference trees. Cached detector output then preserved those invalid results.Fix
spec_from_file_locationandrunpy.run_path, includingPath(...) / ...chains.Verification
16 passed.6679 passed, 164 skipped, 5 failed; the same five failures reproduce on untouched upstream commit3a7735d5(three bash source-directive assertions and one review-prompt assertion collected twice).E731elsewhere in an already-touched test file).