feat(auth): allow pinning the webauth callback port#306
Open
tomaskir wants to merge 2 commits into
Open
Conversation
phase auth (webauth mode) always minted a non-expiring PAT named
username@hostname, with no way to override either. Add two optional flags
and send the values to the Console in the webauth request payload:
- --token-name sets the PAT name (default username@hostname). This fixes
unhelpful names under Docker, where the default becomes root@<container-id>.
- --token-lifetime sets the PAT lifetime, e.g. 7d, 12h, 30m, 60s, 2w
(default: never expires).
The webauth payload moves from the hyphen-joined port-pubKeyHex-patName
string to base64(JSON) { port, publicKey, name, lifetime? }, where lifetime
is in seconds. This is parse-safe for names containing hyphens or other
characters and matches the Console webauth page contract.
Add util.ParseTokenLifetime to convert a lifetime string into seconds.
Console side: phasehq/console#928, phasehq/console#937 (PR phasehq/console#938).
Closes phasehq#302
Closes phasehq#303
Browser login (--mode webauth) starts a local HTTP callback server on a
random port (8002-20002), so the port cannot be known ahead of time. That
breaks webauth inside containers, where Docker port publishing (-p) needs a
fixed port; the only workaround was --network=host, which is Linux-only and
inconsistent on Docker Desktop.
Add a --webauth-port flag and a matching PHASE_WEBAUTH_PORT env var to pin
the callback server to a caller-specified port. The resolved port is used
both for net.Listen and in the webauth payload's port field, so the Console
redirects back to the same fixed port:
phase auth --mode webauth --webauth-port 8002
docker run -p 8002:8002 ... phase auth --mode webauth --webauth-port 8002
Precedence is flag, then env var, then the existing random port. Omitting
both keeps today's behavior, so this is fully backward compatible. Port
resolution is extracted into a pure resolveWebAuthPort helper with unit
tests covering the flag/env/random and validation paths.
Closes phasehq#305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Browser-based login (
phase auth --mode webauth) starts a local HTTP callback server on a random port (roughly 8002-20002), chosen fresh on every run. Because the port is unpredictable, it cannot be mapped with Docker port publishing (-p), so webauth does not work inside containers. The only workaround today is--network=host, which is Linux-only and behaves differently on Docker Desktop (macOS/Windows).This adds a way to pin the callback port:
--webauth-portflag on theauthcommand (webauth mode).PHASE_WEBAUTH_PORTenvironment variable, for container setups where flags are awkward.The resolved port is used both for
net.Listenand in theportfield of the webauth payload, so the Console redirects back to the same fixed port:Precedence is flag, then env var, then the existing random port. Omitting both keeps today's behavior exactly, so the change is fully backward compatible. An out-of-range port (flag or env) or a non-numeric env value is rejected with a clear error.
Port resolution is extracted into a pure
resolveWebAuthPorthelper (mirroring the existingresolveTokenNamehelper), with unit tests covering the flag, env, random-fallback, and validation paths.go vet ./cmd/andgo test ./...pass; theCGO_ENABLED=0build succeeds.Closes #305
Type