Skip to content

feat: sync CLI with dashboard@v1.3.0 - #62

Open
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/cli-dashboard-sync-c17f
Open

feat: sync CLI with dashboard@v1.3.0#62
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/cli-dashboard-sync-c17f

Conversation

@cursor

@cursor cursor Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Upstream version

@photon-ai/dashboard-api@1.3.0 — dashboard release v1.3.0 (c40185d38f6af8c4e88eb84c55f03b99adcdb884).

Routes added/removed/changed

  • Added: GET /api/profile/promotional-status, PATCH /api/profile/promotional-emails
  • Removed: (none)
  • Changed: No route-level changes, but the 1.3.0 type-contract drop replaced every named response interface (SpectrumUser, WhatsAppTemplate, etc.) with opaque records ({ [x: string]: any; ... }). Two list commands relied on the previously inferred Eden types and now require explicit casts at the API boundary:
    • src/commands/projects.tsGET /api/projects
    • src/commands/spectrum/users.tsGET /api/projects/:id/spectrum/users

DTOs introduced in src/lib/types.ts: Project, SpectrumUser, SpectrumUsersPage (per AGENTS.md: cast at the API boundary, not deep in command logic; one shared Project shape).

Snapshot changes

  • (none)

New runtime dependencies

  • (none)

Checklist

  • API type changes come from a @photon-ai/dashboard-api version bump, not hand edits
  • No new runtime deps (or justified above)
  • All snapshot diffs explained above
  • bun run check passes locally
Open in Web View Automation 

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Bump @photon-ai/dashboard-api 1.2.0 -> 1.3.0 and reconcile the two type
errors introduced by the upstream type-contract simplification:

- src/commands/projects.ts: list response now opaque, cast to Project[]
- src/commands/spectrum/users.ts: users page now opaque, cast to
  SpectrumUsersPage (and drop local SpectrumUser duplicate)

Add Project, SpectrumUser, and SpectrumUsersPage DTOs in src/lib/types.ts
(per AGENTS.md: new DTOs live in types.ts, cast at the API boundary).

Refresh UPSTREAM_DIFF.md for the 1.2.0 -> 1.3.0 delta.

No new runtime dependencies, no snapshot changes.

Co-authored-by: citron <lcandy2@users.noreply.github.com>
@github-actions
github-actions Bot marked this pull request as ready for review June 23, 2026 00:20
@github-actions github-actions Bot added agent-review:approved Reviewed by CLI Agent PR Review & Fix automation agent-flow PR generated by agent flow pipeline labels Jun 23, 2026
@github-actions

Copy link
Copy Markdown

Agent PR Review

Scenario: A - Initial review (PR opened by cursor[bot])
Verdict: Approve

What's right

  • API contract change comes from @photon-ai/dashboard-api 1.2.0 to 1.3.0 via package.json + bun.lock only -- no hand-edited API types.
  • No forbidden deps introduced; no Node/npm/pnpm/yarn footprint; .github/workflows/ and scripts/agent-flow/ untouched.
  • Both list-command casts land at the API boundary (src/commands/projects.ts:68, src/commands/spectrum/users.ts:41-42), not deep in command logic -- matches AGENTS.md guidance.
  • New DTOs (Project, SpectrumUser, SpectrumUsersPage) consolidated in src/lib/types.ts; the inline SpectrumUser interface in spectrum/users.ts was correctly deleted to avoid drift. One shared Project shape -- no per-command duplication.
  • Eden treaty pattern preserved: { data, error, status } destructure, error.status === 401 -> SessionExpiredError, no raw fetch().
  • bun run check is green locally (typecheck + 33 tests + build).
  • Snapshot section in PR body is honest -- no snapshot diffs in this changeset.
  • Single upstream version bump, no unrelated refactors bundled in.

Concerns

  • None blocking.

Deferred (acknowledged in PR body)

  • GET /api/profile/promotional-status and PATCH /api/profile/promotional-emails are listed under Added in the PR description but no profile subcommands were wired up for them. Per AGENTS.md this is allowed -- flagging for visibility so a follow-up PR can add photon profile promotional-status / photon profile promotional-emails if/when the product surface needs them.

Final note
Clean, minimal sync to dashboard-api 1.3.0. Marking ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-flow PR generated by agent flow pipeline agent-review:approved Reviewed by CLI Agent PR Review & Fix automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant