feat: sync CLI with dashboard@v1.3.1 - #63
Open
cursor[bot] wants to merge 3 commits into
Open
Conversation
Tracks dashboard release v1.3.1 (sha c2b68e9). The published type contract for @photon-ai/dashboard-api got looser starting at 1.2.3 — request/response payloads are emitted as 'any' rather than the rich DTOs the 1.2.0 bundle carried. Follow-up commits adapt the CLI to the new (degraded) shape. Co-authored-by: citron <lcandy2@users.noreply.github.com>
…ndary
@photon-ai/dashboard-api 1.3.1 emits response payloads as
{ [x: string]: any } rather than typed arrays, so calling `.map` on
the raw Eden `data` now picks up an implicit `any` parameter under
strict TS. Recover the field-level shape with a boundary cast — same
pattern `spectrum/lines.ts` already uses for `SpectrumLine`.
Co-authored-by: citron <lcandy2@users.noreply.github.com>
Co-authored-by: citron <lcandy2@users.noreply.github.com>
|
Agent PR Review Scenario: A - Initial review (PR opened by cursor bot) What is right:
Concerns: None blocking. Deferred (acknowledged in PR body): None - upstream had 0 route additions/removals/signature changes in this window, so there is nothing to defer. Final note: Clean, narrowly-scoped sync PR: one dep bump plus two boundary casts to recover types Eden treaty no longer infers under the looser 1.3.1 published contract. Approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
v1.3.1(shac2b68e9)@photon-ai/dashboard-api:1.2.0→1.3.1Routes added / removed / changed
The route map exposed by
PublicAppis structurally identical betweenv1.2.0andv1.3.1— no routes were added, removed, or had signaturechanges. The notable PRs in this window are app-layer / CI / auth-hardening
that don't touch shapes the CLI consumes (#191, #194, #199, #190).
What did change is the published type bundle: starting at
1.2.3,@photon-ai/dashboard-apiemits request/response bodies asanyandresponse status maps as
{ [x: string]: any }rather than the rich DTOsthe
1.2.0bundle carried. This loosened the inferred type of Edentreaty's
data, which is the source of the (small) CLI breakage.CLI changes
@photon-ai/dashboard-apidevDep to1.3.1.projects listandspectrum users listeach call.map(...)ondata— under the new contractdatais{ [x: string]: any }, sothe callback param was implicitly
anyand trippednoImplicitAny.Recovered the shape with a boundary cast, mirroring the pattern
src/commands/spectrum/lines.tsalready uses forSpectrumLine:src/commands/projects.ts: new localProjectDTO, cast listresponse with
as Project[].src/commands/spectrum/users.ts: castdata?.users ?? []withthe existing
SpectrumUserinterface.UPSTREAM_DIFF.mdrefreshed to describe the1.2.0→1.3.1window.Snapshot changes
(none)
New runtime dependencies
(none)
Verification
bun run check— typecheck + 33 tests + build all pass.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.