feat: sync CLI with dashboard@v1.6.3 - #66
Open
cursor[bot] wants to merge 2 commits into
Open
Conversation
Sync API type contract with photon-hq/dashboard@v1.6.3 (sha e2655b8). The 1.2.0 → 1.6.1 range adds 7 routes (call-registry + profile promotional-emails/status) and degrades every response body to Record<string, any>. Refreshes UPSTREAM_DIFF.md to reflect the new diff. Co-authored-by: citron <lcandy2@users.noreply.github.com>
The 1.6.x @photon-ai/dashboard-api bundle types every response body as Record<string, any>, so Array.prototype.map callbacks no longer get an inferred element type. Introduce Project and SpectrumUser DTOs in src/lib/types.ts and cast at the API boundary (projects.ts list command and spectrum/users.ts list command), matching the AGENTS.md soft rule that new DTOs live in types.ts. Hoists the previously local SpectrumUser interface into the shared module so the add-user handler can share the shape. Co-authored-by: citron <lcandy2@users.noreply.github.com>
Contributor
Author
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Agent PR ReviewScenario: A — Initial review (PR opened by cursor[bot]) What's right
Concerns
Deferred (acknowledged in PR body)
Final noteClean sync PR — scoped to exactly the typecheck fallout from the 1.6.x response-shape degradation, no scope creep. Approving and marking Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream version
@photon-ai/dashboard-api@1.6.1(previously1.2.0)photon-hq/dashboard@v1.6.3, shae2655b880d98a33adada1bee4ce63ed28a41b2baRoutes added/removed/changed
Added (7):
PATCH api.profile.promotional-emailsGET api.profile.promotional-statusGET api.projects.:id.call-registry.profilePATCH api.projects.:id.call-registry.profilePUT api.projects.:id.call-registry.profileGET api.projects.:id.call-registry.registrationsPOST api.projects.:id.call-registry.registrationsRemoved: (none)
Response-shape changes: every route response body in the 1.6.x bundled
.d.tsis nowRecord<string, any>(index-signature only) rather than the strongly-typed per-status shape shipped in 1.2.0. Existing dot-access ondatastill compiles, butArray.prototype.mapcallbacks lose their inferred element type. Fixed by castingdatato a typed DTO at the API boundary in the two list commands that broke (seesrc/commands/projects.tsandsrc/commands/spectrum/users.ts).See
UPSTREAM_DIFF.mdfor the full breakdown.Snapshot changes
New runtime dependencies
Checklist
@photon-ai/dashboard-apiversion bump, not hand editsbun run checkpasses locallyNeed help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.