Skip to content

feat: sync CLI with dashboard@v1.6.3 - #66

Open
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/cli-dashboard-sync-076a
Open

feat: sync CLI with dashboard@v1.6.3#66
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/cli-dashboard-sync-076a

Conversation

@cursor

@cursor cursor Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Upstream version

  • @photon-ai/dashboard-api@1.6.1 (previously 1.2.0)
  • Corresponds to photon-hq/dashboard@v1.6.3, sha e2655b880d98a33adada1bee4ce63ed28a41b2ba

Routes added/removed/changed

Added (7):

  • PATCH api.profile.promotional-emails
  • GET api.profile.promotional-status
  • GET api.projects.:id.call-registry.profile
  • PATCH api.projects.:id.call-registry.profile
  • PUT api.projects.:id.call-registry.profile
  • GET api.projects.:id.call-registry.registrations
  • POST api.projects.:id.call-registry.registrations

Removed: (none)

Response-shape changes: every route response body in the 1.6.x bundled .d.ts is now Record<string, any> (index-signature only) rather than the strongly-typed per-status shape shipped in 1.2.0. Existing dot-access on data still compiles, but Array.prototype.map callbacks lose their inferred element type. Fixed by casting data to a typed DTO at the API boundary in the two list commands that broke (see src/commands/projects.ts and src/commands/spectrum/users.ts).

See UPSTREAM_DIFF.md for the full breakdown.

Snapshot changes

  • (none)

New runtime dependencies

  • (none)

Checklist

  • API type changes come from a @photon-ai/dashboard-api version bump, not hand edits
  • No new runtime deps (or justified above)
  • All snapshot diffs explained above
  • bun run check passes locally
Open in Web View Automation 

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Sync API type contract with photon-hq/dashboard@v1.6.3 (sha e2655b8).
The 1.2.0 → 1.6.1 range adds 7 routes (call-registry + profile
promotional-emails/status) and degrades every response body to
Record<string, any>.

Refreshes UPSTREAM_DIFF.md to reflect the new diff.

Co-authored-by: citron <lcandy2@users.noreply.github.com>
The 1.6.x @photon-ai/dashboard-api bundle types every response body as
Record<string, any>, so Array.prototype.map callbacks no longer get an
inferred element type. Introduce Project and SpectrumUser DTOs in
src/lib/types.ts and cast at the API boundary (projects.ts list command
and spectrum/users.ts list command), matching the AGENTS.md soft rule
that new DTOs live in types.ts.

Hoists the previously local SpectrumUser interface into the shared
module so the add-user handler can share the shape.

Co-authored-by: citron <lcandy2@users.noreply.github.com>
@github-actions
github-actions Bot marked this pull request as ready for review July 9, 2026 03:24
@github-actions github-actions Bot added agent-review:approved Reviewed by CLI Agent PR Review & Fix automation agent-flow PR generated by agent flow pipeline labels Jul 9, 2026
@cursor

cursor Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Agent PR Review

Scenario: A — Initial review (PR opened by cursor[bot])
Verdict: ✅ Approve

What's right

  • Single, focused upstream bump: @photon-ai/dashboard-api 1.2.0 → 1.6.1 in both package.json and bun.lock — no hand-edited API types.
  • No forbidden deps introduced; Bun-only workflow preserved.
  • getApi() + Eden treaty pattern kept intact in both touched commands, with { data, error, status } destructure and SessionExpiredError on 401 (src/commands/projects.ts:63-66, src/commands/spectrum/users.ts:35-39).
  • Response-shape degradation to Record<string, any> handled correctly by casting at the API boundary in the two list commands (projects.ts:69, spectrum/users.ts:41), matching the AGENTS.md soft rule.
  • New Project DTO added to src/lib/types.ts; the previously-inline SpectrumUser interface consolidated into the same file — consistent with "New DTOs go in src/lib/types.ts" and avoids parallel per-command types.
  • Project DTO fields cover everything consumed in the list command (id, name, location, status, platforms, updatedAt).
  • .github/workflows/ and scripts/agent-flow/ untouched. No snapshot changes (accurately reported in PR body).
  • bun install --frozen-lockfile && bun run check is green (typecheck + 36 tests + build).

Concerns

  • None.

Deferred (acknowledged in PR body)

  • New routes not yet wired into commands: api.profile.promotional-emails (PATCH), api.profile.promotional-status (GET), api.projects.:id.call-registry.profile (GET/PATCH/PUT), api.projects.:id.call-registry.registrations (GET/POST). Listed in PR body's "Routes added" section; safe to defer to follow-up PRs.

Final note

Clean sync PR — scoped to exactly the typecheck fallout from the 1.6.x response-shape degradation, no scope creep. Approving and marking Ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-flow PR generated by agent flow pipeline agent-review:approved Reviewed by CLI Agent PR Review & Fix automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant