feat: sync CLI with dashboard@v1.6.4 - #67
Open
cursor[bot] wants to merge 2 commits into
Open
Conversation
Dashboard v1.6.4 tightens SMS OTP send handling to require an authenticated session (photon-hq/dashboard#233) but does not publish a new @photon-ai/dashboard-api version. The bundled API type contract is unchanged from v1.6.3, so this bump catches the CLI up to the current published contract (1.6.1). See UPSTREAM_DIFF.md for the 1.2.0 → 1.6.1 route delta the CLI now compiles against. Co-authored-by: citron <lcandy2@users.noreply.github.com>
The 1.6.x @photon-ai/dashboard-api bundle types every response body as Record<string, any>, so Array.prototype.map callbacks no longer get an inferred element type. Introduce Project and SpectrumUser DTOs in src/lib/types.ts and cast at the API boundary (projects.ts list command and spectrum/users.ts list command), matching the AGENTS.md soft rule that new DTOs live in types.ts. Hoists the previously local SpectrumUser interface into the shared module so the add-user handler can share the shape. Co-authored-by: citron <lcandy2@users.noreply.github.com>
Contributor
Author
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Agent PR ReviewScenario: A — Initial review (PR opened by cursor[bot]) What's right
Concerns
Deferred (acknowledged in PR body)
Final noteClean catch-up sync: the DTO casts at the boundary are the minimal, correct response to the 1.6.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream version
@photon-ai/dashboard-api@1.6.1(packaged forphoton-hq/dashboard@v1.6.4, sha44c3931589ed3c77bb553016706c9334d1a8bd27).Dashboard
v1.6.4only tightens SMS OTP send handling to require an authenticated session (dashboard#233) — it did not publish a new@photon-ai/dashboard-apiversion. The type contract is unchanged fromv1.6.3, so this PR catches the CLI up to the current published contract (1.2.0 → 1.6.1).Routes added/removed/changed
Relative to the
1.2.0we had pinned:PATCH /api/profile/promotional-emailsGET /api/profile/promotional-statusGET /api/projects/:id/call-registry/profilePATCH /api/projects/:id/call-registry/profilePUT /api/projects/:id/call-registry/profileGET /api/projects/:id/call-registry/registrationsPOST /api/projects/:id/call-registry/registrationsRecord<string, any>in the bundled.d.ts, which is why the type fix below is needed. SeeUPSTREAM_DIFF.md.Snapshot changes
New runtime dependencies
Checklist
@photon-ai/dashboard-apiversion bump, not hand editsbun run checkpasses locally (typecheck + 36 tests + build)Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.