feat: sync CLI with dashboard@v1.6.7 - #71
Open
cursor[bot] wants to merge 1 commit into
Open
Conversation
Syncs the type contract from dashboard@v1.6.7 (webhook release). The published dashboard-api package is unchanged since 1.6.1 (v1.6.7 is a security fix in the phone-OTP handler that does not alter the public API surface), so this bump moves us from 1.2.0 -> 1.6.1 as documented in UPSTREAM_DIFF.md. - Add Project + SpectrumUser DTOs in src/lib/types.ts to restore typed views over responses that degrade to Record<string, any> in the bundled .d.ts. - Cast (data ?? []) as Project[] at the projects list boundary and (data?.users ?? []) as SpectrumUser[] at the spectrum users list boundary. - Drop the local SpectrumUser interface in favor of the shared one. Co-authored-by: citron <lcandy2@users.noreply.github.com>
Agent PR ReviewScenario: A — Initial review (PR opened by cursor[bot]) What's right
Concerns
Deferred (acknowledged in PR body)
Final noteMinimal, well-scoped type-contract sync — one upstream bump, no unrelated refactors. Marking ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream version
v1.6.7(3becbeada08dfdedaa195c8f7597dd5e40f07bfc)@photon-ai/dashboard-api@1.6.1(unchanged since the v1.6.1 publish on 2026-07-08 — v1.6.2–v1.6.7 are dashboard-only releases and did not republish the@photon-ai/dashboard-apipackage; v1.6.7 in particular is a phone-OTP quota-lockout security fix that doesn't touch the public API surface).1.2.0→1.6.1sincemainwas still on the pre-1.3.x contract.Routes added/removed/changed
Summary from
UPSTREAM_DIFF.md(36 → 58 routes):GET api.projects.:id.spectrum.avatar-upload-url(replaced by the new avatar upload/commit pair).Only typecheck-affecting deltas are handled here — new CLI surfaces for the added routes are left for follow-up PRs per the automation's Priority-3 guidance.
Snapshot changes
New runtime dependencies
Checklist
@photon-ai/dashboard-apiversion bump, not hand editsbun run checkpasses locallyNotes on the type-contract shape
Every response body in the bundled
.d.tson 1.6.x is currentlyRecord<string, any>(index-signature only), which broke.map((p) => ...)in theprojects listandspectrum users listcommands with TS7006. Fixed by adding typedProjectandSpectrumUserDTOs tosrc/lib/types.tsand castingdata/data.usersat the API boundary (matching the pattern used by prior sync PRs #40–#69). The localSpectrumUserinterface inspectrum/users.tsis now imported from the shared types module.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.