feat: sync CLI with dashboard@v1.6.9 - #74
Open
cursor[bot] wants to merge 1 commit into
Open
Conversation
Co-authored-by: citron <lcandy2@users.noreply.github.com>
|
Agent PR Review — Scenario A (initial review, cursor[bot] draft) — Verdict: Approve. Whats right:
Concerns: none blocking. Deferred (acknowledged in PR body): 23 additive routes (project members, Slack integration, Spectrum avatar upload/commit/delete, voice settings, webhooks, WhatsApp templates, PATCH /profile/spectrum-updates) — no CLI surface change required to make bun run check pass; can land in follow-ups. New v1.6.9 ACCOUNT_SUSPENDED behavior is server-side only. Final note: clean, minimal, single-purpose version bump with the correct DTO-at-boundary pattern — approving and marking ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream version
v1.6.9@300c4f6976206ab994b3f40e632dfdd116de79a3@photon-ai/dashboard-apifrom1.2.0→1.6.9.Routes added/removed/changed
v1.6.9 is a security-hardening release (progressive phone-OTP lockout + account suspension, dashboard#243) plus a release-pipeline repair (dashboard#242) that unsticks
Publish api-publicafter being broken since v1.6.2. The public API contract itself is unchanged from v1.6.8, so this PR replays the accumulated 1.2.0→1.6.x delta already summarized inUPSTREAM_DIFF.md:GET/POST /projects/:id/members,DELETE /projects/:id/members/:memberUserId), Slack integration (GET/PUT/DELETE /projects/:id/slack,GET /projects/:id/slack/installations,DELETE .../:teamId), Spectrum avatar (POST /projects/:id/spectrum/avatar/upload,POST .../commit,DELETE .../avatar), voice settings (GET /projects/:id/voice/settings,PATCH /projects/:id/voice/imessage-enabled,PATCH/DELETE /projects/:id/voice/sip-inbound), webhooks (GET/POST /projects/:id/webhooks,DELETE .../:webhookId), WhatsApp templates (GET/POST /projects/:id/whatsapp/templates,PATCH/DELETE .../:templateId),PATCH /profile/spectrum-updates.GET /projects/:id/spectrum/avatar-upload-url(superseded by the new upload/commit pair).ACCOUNT_SUSPENDEDerror class from the central auth guard, plus phone-OTP lockout/suspension flow — is fully server-side and not exposed as a new route surface, so no CLI change is required.Snapshot changes
New runtime dependencies
Checklist
@photon-ai/dashboard-apiversion bump, not hand editsbun run checkpasses locally (36 tests, typecheck clean, build 0.38 MB)Notes for reviewers
The response body of every route in the 1.6.x bundled
.d.tsdegrades toRecord<string, any>, so the two typed callback sites (projects list,spectrum users list) get TS7006 on.map((p) => ...)/.map((u) => ...). Fixed with the memory-noted pattern: minimalProject+SpectrumUserDTOs insrc/lib/types.tscast once at the API boundary ((data ?? []) as Project[],(data?.users ?? []) as SpectrumUser[]). The localSpectrumUserinterface previously duplicated insrc/commands/spectrum/users.tsis removed in favor of the shared one.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.