feat: sync CLI with dashboard@v1.6.10 - #75
Open
cursor[bot] wants to merge 2 commits into
Open
Conversation
Syncs the CLI with dashboard@v1.6.10. No route additions or removals since 1.6.9; the release is a security-hardening rollup (CAPTCHA gating on email-auth account lifecycle, Turnstile hostname pin, structured SigNoz logging, and an OTLP endpoint fix) and doesn't touch the CLI's public API surface. Compared to the 1.2.0 baseline on main, 7 routes are added (0 removed): profile promotional-status/emails and per-project call-registry profile + registrations. Co-authored-by: citron <lcandy2@users.noreply.github.com>
The 1.6.10 API contract widens the response of `GET /api/projects` and `GET /api/projects/:id/spectrum/users` to `Record<string, any>`, so `data ?? []` no longer produces an array with an inferable element type and `list.map((p) => ...)` fails under `noImplicitAny`. Cast at the API boundary using existing DTOs (SpectrumUser was already declared inline; add a local Project DTO in projects.ts covering the fields the file already reads). Matches the pattern already in src/commands/spectrum/lines.ts. Co-authored-by: citron <lcandy2@users.noreply.github.com>
Agent PR ReviewScenario: A — Initial review (draft PR opened by cursor[bot]) What's right
Concerns
Deferred (acknowledged in PR body)
Final note1.6.10 is a security-hardening rollup with no route removals or shape changes affecting current CLI surface — the two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream version
@photon-ai/dashboard-api@1.6.10(dashboard@v1.6.10, sha676c9cd801aac1ead4b25fb61188fc11aa8336a3)Routes added/removed/changed
Between 1.6.9 and 1.6.10: no route changes. Dashboard v1.6.10 is a security-hardening rollup — Turnstile captcha gating on the email-auth account lifecycle (sign-up / password reset / risk-triggered sign-in), Turnstile hostname pin, structured SigNoz logging across the phone-OTP + auth-security pipelines, and an OTLP endpoint default fix. None of it touches the public API surface.
Against the 1.2.0 baseline pinned on
main(7 routes added, 0 removed, 0 changed):GET /api/profile/promotional-status,PATCH /api/profile/promotional-emailsGET|PUT|PATCH /api/projects/:id/call-registry/profileGET|POST /api/projects/:id/call-registry/registrationsNo CLI command touches those routes today, so nothing needed to change on that front.
Snapshot changes
New runtime dependencies
Checklist
@photon-ai/dashboard-apiversion bump, not hand editsbun run checkpasses locallyNotes
Record<string, any>. That's fine for dot-access but breakslist.map((p) => …)undernoImplicitAnyonGET /api/projects(projects.ts) andGET /api/projects/:id/spectrum/users(spectrum/users.ts). Cast at the API boundary with a local DTO (matches the existing pattern insrc/commands/spectrum/lines.ts) — no other command sites regressed.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.