feat: sync CLI with dashboard@v1.6.11 - #76
Open
cursor[bot] wants to merge 2 commits into
Open
Conversation
Co-authored-by: citron <lcandy2@users.noreply.github.com>
The 1.6.x @photon-ai/dashboard-api bundle types every response body as Record<string, any> (index-signature only), so `data.map((p) => ...)` loses parameter inference and trips TS7006. Cast at the API boundary in projects list and spectrum users list, matching the local-DTO pattern already used in `src/commands/spectrum/lines.ts`. Co-authored-by: citron <lcandy2@users.noreply.github.com>
Agent PR ReviewScenario: A — Initial review (PR opened by cursor[bot]) What's right
Concerns
Deferred (acknowledged in PR body)
Final noteClean, minimal upstream bump with the exact type-boundary shim the 1.6.x bundled types require; readying for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream version
a05def8bd326ac389250630d9569a202f6d97ed8) →@photon-ai/dashboard-api@1.6.11Routes added/removed/changed
v1.6.11 is a security-hardening release (email-domain block list + interaction-required Turnstile + send-never-verify penalty for phone OTP, dashboard#247 + additive migration 0031). It does not touch the public API surface:
diff -qbetween the@photon-ai/dashboard-api@1.6.10and@1.6.11dist/trees is empty (bit-identical.d.ts), so from the CLI's perspective this bump is a no-op.mainis still pinned to@photon-ai/dashboard-api@1.2.0, so the effective delta shipped by this PR (relative tomain) matches the existingUPSTREAM_DIFF.md:projects/:id/members(GET/POST +DELETE /:memberUserId),projects/:id/slack(GET/PUT/DELETE +installationsGET +installations/:teamIdDELETE),projects/:id/spectrum/avatar(DELETE +avatar/uploadPOST +avatar/commitPOST),projects/:id/voice/imessage-enabled(PATCH),projects/:id/voice/settings(GET),projects/:id/voice/sip-inbound(PATCH/DELETE),projects/:id/webhooks(GET/POST +:webhookIdDELETE),projects/:id/whatsapp/templates(GET/POST +:templateIdPATCH/DELETE),profile/spectrum-updates(PATCH).projects/:id/spectrum/avatar-upload-url(GET) — long since migrated to the two-step upload/commit flow in the CLI (see e4e3322).Snapshot changes
New runtime dependencies
Checklist
@photon-ai/dashboard-apiversion bump, not hand editsbun run checkpasses locallyNotes for reviewer
chore(deps): bump @photon-ai/dashboard-api to 1.6.11(package.json + bun.lock), (2)fix(commands): restore typed \list` for projects/spectrum users— the 1.6.x bundled.d.tstypes every response body asRecord<string, any>(index-signature only), solist.map((p) => ...)trips TS7006. Fix casts at the API boundary insrc/commands/projects.ts(new localProjectDTO) andsrc/commands/spectrum/users.ts(reuses the existing localSpectrumUser), matching the pattern already insrc/commands/spectrum/lines.ts`.UPSTREAM_DIFF.mdwas left as-is: its content (23 added / 1 removed) already matches the 1.2.0 → 1.6.11 delta this PR ships againstmain.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.