feat: sync CLI with dashboard@v1.6.15 - #84
Open
cursor[bot] wants to merge 1 commit into
Open
Conversation
Sync CLI type contract with dashboard@v1.6.15 (82d51e4). Upstream changes are auth-only and do not touch any CLI-invoked routes: - dashboard#258 — server-side signup IP suspensions (no route surface change). - dashboard#259 — moves phone OTP send to POST /api/otp/phone2/send and keeps the old /api/otp/phone/send path as a decoy. The CLI never called either route, so no command edits are needed. bun run check stays green. Co-authored-by: citron <lcandy2@users.noreply.github.com>
Agent PR ReviewScenario: A — Initial review (PR opened by cursor[bot]) What's right
Concerns
Deferred (acknowledged in PR body)
Final noteClean minimal sync that catches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream version
@photon-ai/dashboard-api@1.6.15— dashboardv1.6.15(82d51e40947c35def51e38c92fb9edadc89b1408).Routes added/removed/changed
vs. previous CLI-side sync target (
1.6.14):POST /api/otp/phone2/send— the real phone-OTP send path (dashboard#259).POST /api/otp/phone/sendis kept in the type surface as a decoy honeypot.code/captchaTokencosmetically; no shape change.dashboard#258 (temporary signup IP suspensions) is pure server-side abuse control with no public route surface change.
The CLI does not call any
api.otp.*route (phone OTP is a browser/mobile auth flow), so no command edits are required.bun run checkstays green from the version bump alone.Snapshot changes
New runtime dependencies
Checklist
@photon-ai/dashboard-apiversion bump, not hand editsbun run checkpasses locallyNeed help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Note
Low Risk
Dev-dependency version bump and documentation only; no CLI logic or new runtime deps, and OTP routes are outside CLI usage.
Overview
Bumps the typed API surface to
@photon-ai/dashboard-api@1.6.15(dashboardv1.6.15) inpackage.jsonandbun.lock, with no CLI command or runtime dependency changes.UPSTREAM_DIFF.mdis reframed for this sync: it documents the v1.6.14 → v1.6.15 delta (notablyPOST api.otp.phone2.send) and notes that the legacyapi.otp.phone.sendstays in types as a decoy; signup IP suspensions are server-only. The cumulative vs-mainroute counts are updated accordingly.The CLI does not call
api.otp.*routes, so behavior is unchanged beyond staying aligned with upstream types.Reviewed by Cursor Bugbot for commit 4c19fa1. Bugbot is set up for automated code reviews on this repo. Configure here.