New message transformation concept#956
Open
TiMESPLiNTER wants to merge 3 commits into
Open
Conversation
Contributor
|
@TiMESPLiNTER Actually you might want to look into #846 and PRs/issues linked in it's description. Long story short there was a discussion about something similar to what you're proposing, but with the intention of allowing passing arbitrary types as messages to allow custom made serialization on any desired level. I'll look into your PR further when I've got spare time if you dont mind 😄 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to deprecate the current
Serializerapproach and replaces it with a "message transformation concept" which allows to modify the message before after consumption before sending. (For example to de/encode the payload if it's in Avro format.)This PR should not introduce any BC.
I think the
Serializeras of today is really just a workaround for transporting the message headers back when kafka didn't had any support for native headers. As we have it now I think we either should deprecate it and remove it as soon as possible (next major) or replace it with a proper concept (which this PR is a proposal for along with deprecating theSerializer).wdyt?