Wire config options into launch and context creation#121
Merged
Conversation
PlaywrightConfig declared channel, proxy, downloadsDir, videosDir and minNodeVersion but nothing read them. Apply them: - channel, proxy and downloadsPath through new BrowserBuilder setters, applied in PlaywrightClient::createBrowserBuilder(); an explicit setter call wins over the config. - minNodeVersion passed to the NodeBinaryResolver in TransportFactory. - videosDir mapped to recordVideo.dir via PlaywrightConfig::toContextOptions() (@internal), applied both to newContext() and to the default context the server creates at launch (the launch command now carries contextOptions). Proxy credentials are sanitized out of the launch log. The proxy array type requires "server", matching Playwright. Covered end to end: video, download and proxy land in the browser; patch coverage on the changed code is 100%.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlaywrightConfig declared channel, proxy, downloadsDir, videosDir and minNodeVersion but nothing read them.
Updates:
Proxy credentials are sanitized out of the launch log.
The proxy array type requires "server", matching Playwright.