This fixes a bug that appears if you use HISTOGRAM with READ - #1432
Merged
Conversation
If you are using driver to analyze the data in colvar file only using the --noatoms option then the pbc information is not transferred to PLUMED and you get a segmentation fault. As you can see I have resolved this problem in KDE.h by checking if the PbcAction is a null pointer and not calling any function from it if it is.
Member
|
@gtribello This looks fine but we need a regtest that fails before and pass after the change to be sure that the bug is not inadvertently reintroduced in the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR fixes a small bug in the master version of PLUMED that I found when I was reviewing masterclass 21.2.
If you are using driver to analyze the data in colvar file only using the --noatoms option then the pbc information is not transferred to PLUMED and you get a segmentation fault. As you can see I have resolved this problem in KDE.h by checking if the PbcAction is a null pointer and not calling any function from it if it is.
Target release
I would like my code to appear in release 2.11
Type of contribution
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests