Skip to content

Fix sync delegate test crash in Xcode 27 beta. #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbrandonw wants to merge 2 commits into from
+13 −2
Closed

Fix sync delegate test crash in Xcode 27 beta. #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d512b9
Fix sync delegate test crash in Xcode 27 beta.
mbrandonw Jul 24, 2026
ef3cc19
Backwards compat to swift <6.2.3
mbrandonw Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Sources/SQLiteData/CloudKit/SyncEngine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@
let foreignKeysByTableName: [String: [ForeignKey]]
package let syncEngines = LockIsolated<SyncEngines>(SyncEngines())
package let defaultZone: CKRecordZone
let delegate: (any SyncEngineDelegate)?
#if compiler(<6.2.3)
weak var delegate: (any SyncEngineDelegate)?
#else
weak let delegate: (any SyncEngineDelegate)?
#endif
let defaultSyncEngines:
@Sendable (any DatabaseReader, SyncEngine)
-> (private: any SyncEngineProtocol, shared: any SyncEngineProtocol)
Expand Down Expand Up @@ -945,6 +949,14 @@
}
}

#if compiler(<6.2.3)
@available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
extension SyncEngine: @unchecked Sendable {}
#else
@available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
extension SyncEngine: Sendable {}
#endif

extension PrimaryKeyedTable {
@available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
fileprivate static func createTriggers(
Expand Down
1 change: 0 additions & 1 deletion Tests/SQLiteDataTests/CloudKitTests/SyncEngineDelegateTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
@MainActor
final class SyncEngineDelegateTests: BaseCloudKitTests, @unchecked Sendable {
@available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)

@Test($syncEngineDelegate.set(MyDelegate()))
func accountChanged() async throws {
try await userDatabase.userWrite { db in
Expand Down
Loading