fix: keep expected supplier endpoints aligned with overrides - #326
Merged
jorgecuesta merged 5 commits intoJul 30, 2026
Merged
Conversation
Contributor
|
Ey @tsulhc thanks for this contribution, can you change and point it to staging instead of main please. |
miguel502
reviewed
Jul 30, 2026
tsulhc
force-pushed
the
fix/endpoint-overrides-upstream
branch
from
July 30, 2026 15:19
d049729 to
ed96a69
Compare
Author
|
Retargeted the PR to |
miguel502
self-requested a review
July 30, 2026 16:39
miguel502
approved these changes
Jul 30, 2026
jorgecuesta
added a commit
that referenced
this pull request
Jul 30, 2026
* ci: run the test suite in the quality job The quality job ran prettier, lint, build and check-types, but never turbo test — so a green CI said nothing about the 23 test tasks in the workspace. PR #326 was a behavioural fix backed entirely by tests that CI never executed. turbo test costs ~18s locally: its dependsOn is ^build (dependencies only), so the apps' Next builds are not repeated. * ci: use pull_request_target for the staging deploy A pull_request event raised by a PR from a fork gets a read-only GITHUB_TOKEN and no secrets, whatever the permissions block says. When PR #326 (external contributor) was merged, all four build-push jobs failed with 'denied: installation not allowed to Write organization package' and post-deploy was skipped, leaving the release branch out of sync until the deploy was re-run manually via workflow_dispatch. pull_request_target runs in the base-repo context with a read/write token, and keeps github.event.pull_request.labels so the existing 'release' label gate is unchanged. The usual pull_request_target hazard does not apply: both checkouts pin ref: staging, never the PR head, and the job only runs post-merge. * chore(k8s): drop the orphaned middleman-workflows mainnet overlay Real deployments come from pnf-ops (middleman side) and the docker-compose example (operator side). This overlay was last written by the release automation in v0.11.2 (2026-05-18) and has been frozen at that image tag through six releases; deploy-production.yml no longer references it. Its only remaining effect was to read as authoritative production config while declaring NODE_ENV=development and LOG_LEVEL=debug, both inherited from base — which is wrong, and misleading to anyone auditing prod. Tilt is unaffected: every k8s/apps/*/Tiltfile builds ./overlays/dev. * ci: revert the duplicate test step Reverts e0111e9. The quality job already ran `pnpm turbo test` (ci.yml lines 79-80, right after Type check); that commit added a second, identical step. Its premise — that CI never ran the tests — came from a truncated read of the workflow, not from the file. Squash-and-merge collapses this pair away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The provider can repeatedly trigger ServiceMismatch remediation even when the supplier is correctly configured on-chain. The expected-service calculator ignored address-group endpointOverrides, while BuildSupplierServiceConfigHandler applied them when constructing the remediation stake transaction.
This change:
"REST"and normalized numeric keys such as"4"in both validation and stake construction.{protocol}interpolation, avoiding unintended hostname changes and automatic restakes.This keeps validation and remediation aligned without migrating existing endpoint hostnames or stored overrides.
Validation
GitHub Actions CI run #151 passed: