Skip to content

fix(auth): reserve AgentGames route usernames #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rissrice2105-agent wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix(auth): reserve AgentGames route usernames #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/auth/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func IsReservedName(name string) bool {
n := strings.ToLower(name)
if GuestNames[n] || PodNames[n] || JoinNames[n] || DomainNames[n] || AdminNames[n] ||
TorURLNames[n] || TorIRCNames[n] || TorNames[n] || IRCNames[n] || NewsNames[n] ||
MsgNames[n] || systemReserved[n] {
MailNames[n] || GameNames[n] || MsgNames[n] || systemReserved[n] {
return true
}
return strings.HasPrefix(n, "video-") // video-<code> call routes
Expand Down
4 changes: 3 additions & 1 deletion internal/auth/auth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ func TestSanitizeUsername(t *testing.T) {
{"this-name-is-way-too-long-to-accept", "", false}, // >20 after... actually long
{"admin", "admin", false}, // reserved (route/infra)
{"pod", "pod", false}, // reserved route
{"game", "game", false}, // reserved AgentGames route
{"games", "games", false}, // reserved AgentGames route alias
{"video-7f3a", "video-7f3a", false}, // reserved call route
{"WWW", "www", false}, // reserved infra label
}
Expand All @@ -74,7 +76,7 @@ func TestSanitizeUsername(t *testing.T) {
}

func TestIsReservedName(t *testing.T) {
for _, n := range []string{"admin", "bbs", "pod", "join", "domain", "agent", "www", "video", "video-abc", "ROOT"} {
for _, n := range []string{"admin", "bbs", "pod", "join", "domain", "game", "games", "mail", "agent", "www", "video", "video-abc", "ROOT"} {
if !IsReservedName(n) {
t.Errorf("IsReservedName(%q) = false, want true", n)
}
Expand Down