Skip to content

Fix config path#148

Open
bucanero wants to merge 3 commits into
masterfrom
config-dl
Open

Fix config path#148
bucanero wants to merge 3 commits into
masterfrom
config-dl

Conversation

@bucanero

Copy link
Copy Markdown
Contributor

Proper fix for #146 (ref. #147)

thanks to @zeldin for pointing out the mistake.

@bucanero bucanero linked an issue Jun 25, 2026 that may be closed by this pull request
@bucanero bucanero requested review from TheMrIron2 and zeldin June 25, 2026 12:24
@zeldin

zeldin commented Jun 25, 2026

Copy link
Copy Markdown
Member

This is fine. It does miss one finer point of download.sh though. The idea is that by first running download.sh you can then do a build without network access. download.sh runs in archives and calls get-config-scripts.sh, which will download the config scripts to the current directory (i.e. archives; build might not even exist yet). But then when the first build scripts runs (in build), it will call get-config-scripts.sh which will see that there are no config scripts in the current directory (build) and download them again. The next build script will then be able to reuse the downloaded files because by that time get-config-scripts.sh will see that the files are present in build and not download them again.

This is why get-config-scripts.sh always gets the scripts into archives and the build scripts copies them from there in the ps3libraries repo. It's a minor detail though, and the idea has been floated to not do the Savannah download at all, in which case the point is moot. 😄

Update get-config-scripts.sh
@bucanero

Copy link
Copy Markdown
Contributor Author

hi @zeldin , thanks for the insight about the download.sh script 👍

I updated the PR and used the ps3libraries approach, so the config files are downloaded to archives, and then they're used by the binutils scripts when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path error?

2 participants