Fix pug_debug_sources when includeSources contain Buffers - #3474
Open
Hashim1999164 wants to merge 1 commit into
Open
Fix pug_debug_sources when includeSources contain Buffers#3474Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Convert includeSources values with toString('utf8') and only embed
sources for filenames assigned to pug_debug_filename, so pug_rethrow
always receives a string and binary buffers are not serialized.
Fixes pugjs#3290
|
There is no change log for this pull request yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includeSourcesvalues with.toString('utf8')inpug-code-genso NodeBuffers fromfs.readserialize as strings forpug_rethrow.pug_debug_filename, avoiding binary buffers in the generated debug map.Fixes #3290
Test plan
includeSourcesvalues asBuffers; runtime error includes source context instead of failing insidepug_rethrow.includeSourcesare omitted frompug_debug_sources.npx jest packages/pug/test/pug.test.jspasses (including snapshots).