Run ruff formatting and unit tests for all pull requests.#331
Merged
Conversation
gubaidulinvadim
approved these changes
Jul 10, 2026
gubaidulinvadim
left a comment
gubaidulinvadim
left a comment
Contributor
There was a problem hiding this comment.
I'm surprised it's set up only for main. Anyhow, I think we've shared how to set up a git hook to check ruff on commit.
Member
Author
|
Yes, if you install with the dev dependencies you also get the pre installation hooks. Its' only if you forget to install those dependencies that you can commit without it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest that we update the workflow to run ruff formatting and unit tests for all pull requests and not just when pushing to main so we can catch the errors as early as possible.