gh-146102：Fix cross-interpreter NotShareableError ref handling#151578
Open
lpyu001 wants to merge 1 commit into
Open
gh-146102：Fix cross-interpreter NotShareableError ref handling#151578lpyu001 wants to merge 1 commit into
lpyu001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two ownership issues:
_ensure_notshareableerror()now returns immediately when the current raised exception is already aNotShareableError. The function had restoredctxto the thread state but then continued using it, even though ownership had been handed back._PyXI_UnwrapNotShareableError()now decrefs the exception taken from the thread state if_PyXI_InitFailure()fails, avoiding a leaked exception reference on that error path.The
_pop_preserved()shadowed-variable leak is already fixed on this branch, so this PR does not touch it.glist：https://gist.github.com/devdanzin/a56b8cb579b1950b4206e8a42d6be650