Improve the styling of the conformance results page#2307
Open
ngnpope wants to merge 29 commits into
Open
Conversation
- `<span>` cannot be a parent of `<p>` - `#bottom` must be unique
Add `th[scope]` attributes and split groups into separate `<tbody>`s.
Partial compliance is given half a mark, a pass a full mark.
To reduce the noise when reviewing, hide the generated output of the conformance test results.
a05617c to
99f1536
Compare
Author
|
I timed that terribly badly... 😂 Rebased on top of #2308. You can preview the changes here. |
Collaborator
Are you really honest here? I would not have guessed that you wrote the issue description in a hundred years. This looks 100% like AI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐞 Issues Identified
Looking at the conformance results page, there were a number of issues that I noticed:
idattributes,<span>parent of<p><th>used for all table cells, not only header cellsclassattributespointercursor, even if there is no tooltip (or other action)🏗️ List of Changes
This pull request aims to improve the generated output and make it easier to maintain.
The following changes have been made:
tomllibfrom the standard library instead oftomliconformance/pyproject.tomlhasrequires-python = "==3.12.*"jinja2for templates instead of manually joining lists of tags<th>for heading cells, not all table cells<thead>for the header row with type checker names<tbody>for each group of testsscopeattributes for header cells<colgroup>and<col>to reduce excessclassattributesclassattributeshelpcursor instead ofpointer, and only where there are tooltipslight-dark(), etc.1for a pass and0.5for a partial resultPasses validation on validator.w3.org (with the exception of a known bug in the validator for nested CSS) and also scores 100 for performance, accessibility, and SEO in Google Chrome DevTools Lighthouse tool.
🔮 Future Ideas
🤖 AI Disclosure
No AI was involved in creating this pull request.
🖼️ Screenshots
First Load
Sticky Table Header
Tooltip Rendering
Theme Selector