fix(helm): add configurable namespace override to chart templates - #484
Open
casinesque wants to merge 2 commits into
Open
fix(helm): add configurable namespace override to chart templates#484casinesque wants to merge 2 commits into
casinesque wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an explicit
metadata.namespaceto all chart templates, defaulting to.Release.Namespace, and exposes anamespacevalue to override it.Closes #432
Why
I thought this could be useful since some tools (e.g. GitOps controllers using
helm templateunder the hood) expect resources to declarenamespaceexplicitly rather than relying on the implicit release namespace.
Change
The fix was quite simple: added
namespace: {{ .Values.namespace | default .Release.Namespace }}to
metadatain each template, and added anamespace: ""field invalues.yamlto allow overriding the default.Testing
helm template .— renders identically to before (fallback to.Release.Namespace, no behavior change)helm template . --set namespace=custom-ns— all resources render withnamespace: custom-nsBackwards compatibility
Non-breaking: default behavior is unchanged when
namespaceis not set.