Skip to content

[#532] Apply Rector follow-up#557

Merged
armanist merged 1 commit into
quantum-php:masterfrom
armanist:issue/532-rector-followup
Jul 6, 2026
Merged

[#532] Apply Rector follow-up#557
armanist merged 1 commit into
quantum-php:masterfrom
armanist:issue/532-rector-followup

Conversation

@armanist

@armanist armanist commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Improved internal list normalization to make string handling more explicit and consistent.
    • Removed an unused configuration rule, with no change to app behavior.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ea33c38b-e744-4f04-8eef-1b1a866dbfbf

📥 Commits

Reviewing files that changed from the base of the PR and between cd740e9 and 41eaa54.

📒 Files selected for processing (2)
  • rector.php
  • src/Validation/Traits/Lists.php
💤 Files with no reviewable changes (1)
  • rector.php

📝 Walkthrough

Walkthrough

This PR removes the StrictStringParamConcatRector rule and its scoped configuration from rector.php, and adds explicit : string return type declarations to array_map callbacks in containsList() and doesntContainsList() within the Lists trait.

Changes

Config and validation trait tweaks

Layer / File(s) Summary
Remove Rector rule configuration
rector.php
Removed the StrictStringParamConcatRector import and its scoped rule entry targeting Criteria.php.
Explicit return types in Lists trait
src/Validation/Traits/Lists.php
Added explicit : string return type declarations to array_map callbacks in containsList() and doesntContainsList().

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the changes, which are a small Rector follow-up affecting rector.php and a Rector-triggered typing adjustment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@armanist armanist merged commit c4b6069 into quantum-php:master Jul 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants