fix(windows): make Settings and What's New standard single-Space windows#283
Merged
Merged
Conversation
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Settings and the "What's New" window now behave like standard macOS app windows instead of floating overlays. They open in a regular desktop Space, pull you to that Space when summoned from over a fullscreen app, and stay put when you switch to a different fullscreen app. The ask-bar and chat overlay are unchanged: they still float over every Space, including fullscreen ones, which is the core of the product.
Why
Both windows were configured as overlays (
can_join_all_spaces+full_screen_auxiliary), so they appeared on every Space and followed the user into any fullscreen app. That is right for the spotlight-style overlay but wrong for window-style surfaces, which should live in a single Space like System Settings and other Mac apps.Managedis the AppKit primitive for an ordinary single-Space app window.Key changes
Managedcollection behavior instead of the overlay flags, so it is bound to one Space.Managed, normal window level (so another app the user clicks rises above it), and it now flips toRegularactivation while open (Dock icon + normal layering) so activation pulls the user to its Space. AManagedwindow shown without activating would land on a Space the user cannot see.UPDATE_OPENflag feeding the activation-policy decision, with the matchingupdateclose handler and Dock-click (Reopen) refocus path.Testing
bun run test:all:coverage: frontend 2210 tests + 100% coverage; backend tests pass;--fail-under-lines 100holds.bun run validate-build: clippy, fmt, typecheck, and a full signed app bundle, all clean.Note: the Space behavior itself (pull-to-Space, no-follow) is outside the automated gates and is verified by hand on a real machine with fullscreen Spaces. Collection behavior is set only in Rust via
set_collection_behavior; there is novisibleOnAllWorkspacesintauri.conf.json, so this is the single source of truth.