fix: never refresh OAuth token without the config lock - #1021
Open
amanharshx wants to merge 1 commit into
Open
Conversation
On config-lock acquisition failure, ensure_valid_token now returns a retryable ConfigLockBusy error instead of refreshing unlocked. Refreshing without the lock lets a parallel process present an already-rotated refresh token, which the server treats as reuse and revokes the entire grant (a hard logout). A retry is cheap and recoverable; a revoked grant is not. Also always reload + re-check expiry under the lock, split ConfigLockGuard::acquire into a testable acquire_at, and drop the misleading unlocked-refresh warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the config lock can't be acquired, ensure_valid_token now returns a retryable ConfigLockBusy error instead of refreshing unlocked. An unlocked refresh lets a parallel process present an already-rotated refresh token, which the server treats as reuse and revokes the whole grant (a hard logout). A retry is cheap and recoverable, but a revoked grant is not.