Skip to content

Fix clean typechecking and benchmark output hygiene#120

Merged
zacharyr0th merged 2 commits into
mainfrom
agent/fix-clean-typecheck-and-benchmark-output
Jul 23, 2026
Merged

Fix clean typechecking and benchmark output hygiene#120
zacharyr0th merged 2 commits into
mainfrom
agent/fix-clean-typecheck-and-benchmark-output

Conversation

@zacharyr0th

Copy link
Copy Markdown
Contributor

What changed

  • install all optional dependencies for static typechecking
  • ignore local benchmark run outputs

Why

A clean checkout failed mypy because provenance types come from the optional cryptography extra. Benchmark result files can also contain extracted text and should stay local.

Checks

  • bun run validate

@admin-raintree admin-raintree left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated locally and ready to merge.

@zacharyr0th
zacharyr0th force-pushed the agent/fix-clean-typecheck-and-benchmark-output branch from 0cc68ac to b40d6f5 Compare July 23, 2026 22:10

@admin-raintree admin-raintree left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean-checkout validation passed, including the repaired typecheck.

@zacharyr0th
zacharyr0th merged commit 69ea177 into main Jul 23, 2026
18 checks passed
@zacharyr0th
zacharyr0th deleted the agent/fix-clean-typecheck-and-benchmark-output branch July 23, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants