VPAAMP-881 Migrate to HEAD of middleware-player-interface - #1815
Open
pstroffolino wants to merge 3 commits into
Open
VPAAMP-881 Migrate to HEAD of middleware-player-interface#1815pstroffolino wants to merge 3 commits into
pstroffolino wants to merge 3 commits into
Conversation
Remove dependency on patched middleware commit bd2b3b1. All required features (setPtsOffset, GStreamer base-1.0 fixes, OpenSSL includes) are now present natively in middleware-player-interface HEAD (0.3.1). Changes: - scripts/install_options.sh: Remove pinned commit bd2b3b1, use HEAD - scripts/install_middleware_interfaces.sh: Remove commit checkout logic (sibling and clone paths) and patch application block - .github/workflows/L1-tests.yml: Remove git checkout bd2b3b1 and patch application steps; clone HEAD directly - test/utests/fakes/CMakeLists.txt: Remove deprecated internal aamp/middleware fallback; FATAL_ERROR if middleware not found - test/utests/tests/CommonTestIncludes.cmake: Same - remove deprecated aamp/middleware fallback paths - OSX/patches/middleware-fixes-4c1d90a.patch: Archived to OSX/patches/archive/ with README explaining historical context - OSX/patches/middleware-build-fixes-summary.md: Updated to note patch is no longer applied (VPAAMP-881) Verified: macOS clean build succeeds with middleware-player-interface develop branch (0165183, release 0.3.1) without any patches. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
pstroffolino
force-pushed
the
feature/VPAAMP-881
branch
3 times, most recently
from
August 2, 2026 06:09
9af618f to
c464372
Compare
DrmSession gained four new protected members in middleware develop (lifecycle guard fix): mLifecycleMutex, mLifecycleCV, mActiveOperations, mMarkedForDestruction. The fake DrmSession constructor in FakeAampDRMSessionManager.cpp was not initializing these members, leaving mActiveOperations as garbage on Linux/glibc. This caused heap corruption (glibc sysmalloc assertion) in multi-key and concurrency tests on Linux CI, while macOS passed due to its more lenient allocator behavior. Fix: 1. FakeAampDRMSessionManager.cpp: initialize all four new members in the fake DrmSession constructor, matching the real DrmSession.cpp. 2. AampDRMLicPreFetcherTestCases.cpp / AampDRMLicManagerTestCases.cpp: add ~TestDrmSession() that marks for destruction and waits for in-flight operations to drain before delete, mirroring what real DrmSessionManager now does for production sessions. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
pstroffolino
force-pushed
the
feature/VPAAMP-881
branch
from
August 2, 2026 06:58
c464372 to
478e9d6
Compare
…ally work The commit ID option was parsed and exported but never used when cloning middleware-player-interface from GitHub. Added logic to checkout the specified commit after cloning, with fallback to HEAD if checkout fails. This makes the option functional as documented. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dependency on patched middleware commit bd2b3b1. All required features (setPtsOffset, GStreamer base-1.0 fixes, OpenSSL includes) are now present natively in middleware-player-interface HEAD (0.3.1).
Changes:
Verified: macOS clean build succeeds with middleware-player-interface develop branch (0165183, release 0.3.1) without any patches.
Generated with Devin