chore: update maintenance dependencies#517
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Code Review
This pull request updates the project's dependencies to React 19, TypeScript 6, and ESLint 9, introducing a flat ESLint configuration and compatibility type definitions. However, several feedback points should be addressed: strict type-checking flags in tsconfig.json should remain enabled to prevent runtime errors; manual 'any' declarations for Jest globals in global.d.ts should be removed to preserve strong typing; the deprecated 'ban-types' rule in ESLint should be updated to '@typescript-eslint/no-restricted-types'; global overrides for React 19 types in react-compat.d.ts should be avoided in favor of codebase compatibility; and '@typescript-eslint/no-unused-vars' should not be disabled globally.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "noImplicitAny": false, | ||
| "strictNullChecks": false, | ||
| "strictPropertyInitialization": false, | ||
| "strictFunctionTypes": false, | ||
| "strict": false, | ||
| "noImplicitThis": false, | ||
| "strictBindCallApply": false |
There was a problem hiding this comment.
Disabling strict mode and other strictness flags (strictNullChecks, noImplicitAny, etc.) significantly reduces type safety and increases the risk of runtime errors (such as TypeError: Cannot read properties of undefined). It is highly recommended to keep strict: true enabled and resolve any type errors directly in the codebase.
| declare const describe: any; | ||
| declare const it: any; | ||
| declare const test: any; | ||
| declare const beforeEach: any; | ||
| declare const afterEach: any; | ||
| declare const beforeAll: any; | ||
| declare const afterAll: any; | ||
| declare const expect: any; |
There was a problem hiding this comment.
| '@typescript-eslint/ban-types': 'off', | ||
| '@typescript-eslint/no-empty-object-type': 'off', | ||
| '@typescript-eslint/no-unsafe-function-type': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off', |
There was a problem hiding this comment.
Disabling @typescript-eslint/no-unused-vars globally is discouraged as it allows unused variables and imports to go unnoticed, leading to dead code. Consider setting it to warn or error with configuration to ignore variables prefixed with an underscore.
| '@typescript-eslint/no-unused-vars': 'off', | |
| '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }], |
| ...next.plugins['@typescript-eslint'], | ||
| rules: { | ||
| ...next.plugins['@typescript-eslint'].rules, | ||
| 'ban-types': noopRule, |
There was a problem hiding this comment.
The ban-types rule has been removed in @typescript-eslint v8. This compatibility shim and any references to ban-types should be updated to @typescript-eslint/no-restricted-types to avoid ESLint configuration errors or warnings.
| declare module 'react' { | ||
| type ReactText = string | number; | ||
| function useRef<T = undefined>(): React.MutableRefObject<T | undefined>; | ||
| function isValidElement<P = any>(object: {} | null | undefined): object is React.ReactElement<P>; | ||
| function cloneElement<P = any>( | ||
| element: React.ReactElement<P>, | ||
| props?: (Partial<P> & React.Attributes) | null, | ||
| ...children: React.ReactNode[] | ||
| ): React.ReactElement<P>; | ||
| } |
There was a problem hiding this comment.
Overriding the global react module types to add back deprecated types like ReactText and override core hooks/methods (useRef, isValidElement, cloneElement) is fragile and can cause type conflicts for consumers of this library. It is highly recommended to update the codebase to be fully compatible with React 19 types instead of using global type overrides.
❌ Deploy failed
📋 Build log (last lines)🤖 Powered by surge-preview |
|||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #517 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 17 17
Lines 541 541
Branches 164 165 +1
=======================================
Hits 538 538
Misses 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
React Doctor skipped this pull request — it changed no React files. Reviewed by React Doctor for commit |
|
Deployment failed with the following error: Learn More: https://vercel.com/react-component?upgradeToPro=build-rate-limit |

Summary
Test Plan