feat: add geometry-first rendered-line motion#2
Open
saseungmin wants to merge 1 commit into
Open
Conversation
React Native titles need motion units that match the lines the platform lays out. The overlay renderer keeps one source paragraph as truth and reuses measured line masks. Frame transforms stop scale and pulse from clipping against the renderer's own mask. lineReveal keeps only its relative Y movement inside the line mask. Type and declaration gates keep private renderer state outside the package surface. Constraint: Preserve controls, progress, accessibility, reduced motion, and fallback behavior Constraint: Preserve the pnpm workspace and custom source condition Rejected: Reconstruct lines from tokens | React Native layout stays the source of truth Rejected: Add scale padding or bleed props | transforms cannot reserve layout reliably Confidence: high Scope-risk: broad Directive: Keep line motion geometry-first and retain one progress owner Tested: Node 24 format, lint, typecheck, 14 suites / 190 tests, and package build Tested: Declaration audit and independent code-reviewer APPROVE / architect CLEAR Not-tested: Post-change iOS and Android pixel comparison for transform-origin rounding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overlayText()andlineReveal()for motion based on lines rendered by React NativeArchitecture
Verification
pnpm run format:checkpnpm run lintpnpm run typecheckpnpm run test- 14 suites / 190 testspnpm run build- declaration surface check passedManual follow-up