Feat: Add optional clock to TV player#2941
Open
JelleSThijs wants to merge 12 commits into
Open
Conversation
JelleSThijs
commented
Jun 22, 2026
JelleSThijs
commented
- Add a new TV layout clock setting to the player option menu.
- Add a new Text clock to the tv player layout. Take 12AM/PM and 24 hour clocks into account.
2 tasks
fire-light42
requested changes
Jun 22, 2026
fire-light42
left a comment
fire-light42
left a comment
Collaborator
There was a problem hiding this comment.
A very elegant solution with TextClock! Good code and clean implementation.
There are only some minor nitpicks which are difficult (if not impossible) for a first-time contributor to know about.
… the fully shared ui logic
- Transfer tv_layout_clock_key from strings.xml to donottranslate-strings.xml. - Rename the string value to adhere to the already existing keys.
- Use playerBinding?.playerVideoClock instead of using getViewById. - Use isVisible instead of an if statement for the visibility logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.