fix(ci): skip Slack notification for fork PR reviews#55
Open
stevefulme1 wants to merge 1 commit into
Open
Conversation
pull_request_review events from fork PRs cannot access repo secrets, causing the Slack notification step to fail with "Missing input". Skip the notify job for fork PR reviews since the webhook URL is unavailable. pull_request_target events are unaffected and continue to send notifications for all PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_reviewevents from fork PRs cannot access repo secrets, causing the Slack notification step to fail withMissing input! Either a method or webhook is requiredpull_request_reviewand the PR originates from a fork (head repo differs from base repo)pull_request_targetevents are unaffected and continue to notify for all PRs regardless of originTest plan
pull_request_targetevents (open/close/merge) still work for all PRs