Skip to content

[GITOPS-10474]: Configure TLS MinVersion,MaxVersion,CipherSuites#68

Merged
openshift-merge-bot[bot] merged 3 commits into
redhat-developer:masterfrom
akhilnittala:usr/akhil/GITOPS-10474
Jul 17, 2026
Merged

[GITOPS-10474]: Configure TLS MinVersion,MaxVersion,CipherSuites#68
openshift-merge-bot[bot] merged 3 commits into
redhat-developer:masterfrom
akhilnittala:usr/akhil/GITOPS-10474

Conversation

@akhilnittala

Copy link
Copy Markdown
Member

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:

Exposing tlsminversion,tlsmaxversion,tlsciphersuites as env or command line arguments to configure.
Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?
https://redhat.atlassian.net/browse/GITOPS-10474
How to test changes / Special notes to the reviewer:

deploy gitops-backend as mentioned in README.

Signed-off-by: akhil nittala <nakhil@redhat.com>
@openshift-ci openshift-ci Bot added the kind/enhancement New feature or request label Jul 15, 2026
@openshift-ci
openshift-ci Bot requested review from chetan-rns and trdoyle81 July 15, 2026 14:22

@chetan-rns chetan-rns left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think we should move the TLS code to a separate file with unit tests. Everything else looks good to me.

Comment thread pkg/cmd/root.go Outdated
Comment thread pkg/cmd/root.go Outdated
Comment thread pkg/cmd/root.go Outdated
Signed-off-by: akhil nittala <nakhil@redhat.com>
Signed-off-by: akhil nittala <nakhil@redhat.com>
@akhilnittala

Copy link
Copy Markdown
Member Author

/retest-required

@chetan-rns chetan-rns left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@chetan-rns

Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 3bdb2a7 into redhat-developer:master Jul 17, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants