Raise the minimum handler stack to 16K#9
Open
codewiz wants to merge 2 commits into
Open
Conversation
The handler's deep paths (directory traversal, name normalization) can use more stack than a mountlist typically grants. The previous 4K/8K swap thresholds let a small mountlist stack through unhelped, risking an overflow; guarantee at least 16K by swapping to a private stack when the supplied one is smaller.
Match the handler's minimum stack so example mountlists don't trigger a stack swap on first use.
Contributor
Author
|
Found while investigating issue #4. |
|
A good device/program detect low stack and extend it own stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handler's deep paths (directory traversal, name normalization) can use more stack than a mountlist typically grants.
I got a MuGA low stack hit with 8KB of stack, and the -test version needs some more for RawDoFmt. Technically we could get away with 10-12KB of stack, but let's go safe with 16KB, matching the ROM filesystem.