docs(g6_03): trial-params (0x08) re-layout — gain int16 + duration field#65
Open
floesche wants to merge 1 commit into
Open
docs(g6_03): trial-params (0x08) re-layout — gain int16 + duration field#65floesche wants to merge 1 commit into
floesche wants to merge 1 commit into
Conversation
Update the 0x08 payload table for the canonical re-layout (init_pos/gain swap, gain widened to int16, new duration field) and delete the "Known, intentional divergences" row for 0x08; the gain-width/runtime gap it tracked as open is now closed.
mbreiser
added a commit
that referenced
this pull request
Jul 8, 2026
…D/0x1E Documents the layout merged in Arena-Firmware PR #39 (c3475fd): optional 12th param byte on trial-params (0 = stored duty, 1-255 = per-trial override; frame 0x0C or 0x0D), applied at transmit time with the pattern file untouched. Scope/lifecycle: re-declared per trial, none on 0x03, cleared on all-off. Stacked on the #65 canonical-relayout docs; the withdrawn 0x1D/0x1E section from the previous revision of this PR is gone. Ride-alongs: registry row 0x08 frame lengths; Mode-4 gain prose int8→int16; review-notes row marked resolved; 0x03 note documents duty clearing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the 0x08 payload table for the canonical re-layout (init_pos/gain swap, gain widened to int16, new duration field) and delete the "Known, intentional divergences" row for 0x08; the gain-width/runtime gap it tracked as open is now closed.
Part of the reiserlab/LED-Display_G6_Firmware_Arena#35 change across repos