Skip to content

feat(auth): local auth - #938

Draft
JosephKav wants to merge 21 commits into
masterfrom
feat/auth
Draft

feat(auth): local auth#938
JosephKav wants to merge 21 commits into
masterfrom
feat/auth

Conversation

@JosephKav

Copy link
Copy Markdown
Collaborator

No description provided.

@JosephKav JosephKav added enhancement New feature or request javascript Pull requests that update Javascript code go Pull requests that update Go code labels Jul 23, 2026
Comment thread web/api/v1/http-api-auth.go Fixed
Comment thread web/api/v1/http-api-auth.go Fixed
@JosephKav JosephKav mentioned this pull request Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.74776% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.41%. Comparing base (43104b9) to head (97bce80).

Files with missing lines Patch % Lines
auth/store/store.go 97.08% 3 Missing and 2 partials ⚠️
auth/store/sessions.go 95.66% 2 Missing and 2 partials ⚠️
auth/store/users.go 98.74% 2 Missing and 2 partials ⚠️
cmd/argus/main.go 40.00% 2 Missing and 1 partial ⚠️
auth/store/groups.go 99.35% 1 Missing and 1 partial ⚠️
auth/store/test/faultdb.go 97.65% 1 Missing and 1 partial ⚠️
cmd/argus/auth.go 97.78% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
- Coverage   99.71%   99.41%   -0.30%     
==========================================
  Files         204      223      +19     
  Lines       12946    15360    +2414     
==========================================
+ Hits        12908    15268    +2360     
- Misses         33       68      +35     
- Partials        5       24      +19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread cmd/argus/auth.go Dismissed
@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown

✅ Playwright Test Results

Count
✅ Passed 379
❌ Failed 0
🔄 Flaky 0
⏭️ Skipped 4

Duration: 1221.8s

View screenshots & full report

@JosephKav
JosephKav force-pushed the feat/auth branch 3 times, most recently from b07a50a to 5299f49 Compare July 28, 2026 23:43
JosephKav added 17 commits July 29, 2026 15:57
- Write configs to one process-lifetime temp dir (created in TestMain), so
  late debounced saves always find it and the save-drain sleeps can go.
- Sweep stray temp dirs at startup, since a killed/timed-out run can't run
  the end-of-run cleanup.
- Resolve the GitHub token from ${GITHUB_TOKEN} at read time where it's used
  (api, cmd) and use an inert placeholder where it isn't (config, web), so no
  real token is persisted to disk.
- Cap concurrent sessions per user; evict the least-recently active
  session on login past the cap.
- Kick WebSocket clients on logout, session eviction, grant/group
  edits, or service tag changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update Go code javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants