Conversation
A PUT to /api/v1/service/config or POST to /api/v1/service/new without an `id` in the payload was incorrectly accepted, while still returning `200 OK`. An edit replaced the target service with one whose ID was an empty string, leaving an invalid entry in its place in the service order. A create added one under that same empty ID. Both endpoints now reject requests with no `id`, with `400 Bad Request`, leaving the service and service order unchanged. `AddService` and `RenameService` also reject empty IDs. Existing configurations containing a service with an empty ID are left unchanged, but with a warning log identifying the issue, as they require manual repair. Also document that the endpoint body replaces an existing service rather than merging into it.
The service edit payload takes an array for notify and webhook entries keyed by their `name`, so an entry sent without one was stored under the empty string, and two entries sharing a name silently collapsed into the last one. Both were accepted with `200 OK`. Each is now rejected with `400 Bad Request`, naming the offending index (matching what the web UI already enforces).
JosephKav
added
bug
announceEdit skipped the broadcast when RemoveUnchanged left the summary empty, so edits to fields absent from it reached no other client. Those clients kept the service config cached for the staleTime, so reopening the edit modal repopulated the form from stale data and saving silently reverted the edit. Also fixes the rename branch merging cached data over the new ID.
JosephKav
force-pushed
the
940-bug-put-apiv1serviceconfig-with-no-id-in-the-payload-destroys-the-service-and-corrupts-the-order-list
branch
from
July 26, 2026 04:33
75c1a75 to
256f51c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #943 +/- ##
==========================================
+ Coverage 99.71% 99.71% +0.01%
==========================================
Files 204 204
Lines 12946 12988 +42
==========================================
+ Hits 12908 12950 +42
Misses 33 33
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ Playwright Test Results
Duration: 1057.8s |
Argus-Bot
approved these changes
Jul 28, 2026
JosephKav
deleted the
940-bug-put-apiv1serviceconfig-with-no-id-in-the-payload-destroys-the-service-and-corrupts-the-order-list
branch
July 28, 2026 01:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idin the payload - accepted with200 OK, replacing the servicewith an empty-ID one and corrupting the order. Now a
400.name- stored under"", or silently collapsed into the last one. Now a400, naming the index.clients kept a stale config for the 5 minute
staleTimeand could silentlyrevert the edit on their next save. Now always announced.
Fixes #940