fix(captcha): guard against duplicate callback delivery race#19
Merged
Conversation
Double-tapping the verify button raced two callback deliveries through check_user_profile before either delivery removed the pending captcha row, risking a double unrestrict_user + start_new_user_probation call. remove_pending_captcha's existing delete-rowcount now gates finalization so only the delivery that actually removes the row proceeds. Also cleans trailing whitespace in user_checker.py and ignores the local .tokensave/ cache directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unrestrict_user+start_new_user_probationbefore either cancelled the timeout job.remove_pending_captcha's existing delete-rowcount return value now gates finalization: only the delivery that actually removes the row proceeds; the duplicate acks quietly and exits.user_checker.py..tokensave/cache directory.Test plan
uv run pytest— 987 passeduv run ruff check .— cleanuv run mypy src/bot/ tests/— cleancaptcha.pyanduser_checker.pytest_duplicate_callback_delivery_ignoredcovers the race guard