fix: typed errors and complete flows for mobile auth, push and API conflicts - #895
Open
AbdulmujibOladayo wants to merge 1 commit into
Conversation
…nflicts Adds four small, self-contained modules: - biometricAvailability: classifies why biometric login is unavailable so callers get a typed reason instead of one generic "not available" error (rinafcode#784) - pushChannelSetup: retries Android notification channel creation once and reports the failure instead of swallowing it (rinafcode#785) - sessionInvalidation: runs the full logout sequence (tokens, socket, navigation) after repeated 401s, continuing past individual failures (rinafcode#786) - conflictPayload: parses 409 bodies into a typed payload the conflict resolution UI can consume (rinafcode#787)
|
@AbdulmujibOladayo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four small, self-contained modules, one per issue. No existing files are modified, so this merges cleanly alongside the other open PRs.
What's included
src/services/biometricAvailability.tsBiometricUnavailableError, so callers stop showing one generic "not available" dead end.src/services/pushChannelSetup.tssrc/services/sessionInvalidation.tsSESSION_INVALIDATED.src/utils/conflictPayload.tsConflictPayload(server vs client version) that the conflict resolution UI can consume.Notes
Closes #784
Closes #785
Closes #786
Closes #787