fix: make auth and storage failures explicit and recoverable - #896
Open
soundsng wants to merge 1 commit into
Open
fix: make auth and storage failures explicit and recoverable#896soundsng wants to merge 1 commit into
soundsng wants to merge 1 commit into
Conversation
Adds four small, self-contained modules: - timeoutRetryPolicy: decides which timed-out requests belong in the offline queue so writes are replayed on reconnect instead of silently lost (rinafcode#788) - secureStorageHealth: round-trips a probe through the secure store and fails fatally, so the app cannot boot into an insecure fallback (rinafcode#789) - authInitError: structured AuthInitializationError naming the missing dependency instead of a bare "not initialized" error (rinafcode#790) - authErrorCategory: categorises auth failures and maps each to its own recovery action (rinafcode#791)
|
@soundsng Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four small, self-contained modules, one per issue. No existing files are modified, so this merges cleanly alongside the other open PRs.
What's included
src/utils/timeoutRetryPolicy.tsECONNABORTED) requests belong in the offline queue: writes are replayed on reconnect, GETs are re-fetched instead of replayed.src/services/secureStorageHealth.tsSecureStorageUnavailableError(with a recovery hint) so the app cannot boot into a plaintext fallback.src/types/authInitError.tsAuthInitializationErrorthat names the missing dependency, replacing the bare "not initialized" error. Includes aninstanceofguard and an assert helper.src/utils/authErrorCategory.tsNotes
Closes #788
Closes #789
Closes #790
Closes #791