fix: stop logging leaking data and stop errors disappearing silently - #897
Open
benzeneCLI wants to merge 1 commit into
Open
fix: stop logging leaking data and stop errors disappearing silently#897benzeneCLI wants to merge 1 commit into
benzeneCLI wants to merge 1 commit into
Conversation
Adds four small, self-contained modules: - sanitizeErrorResponse: recursively redacts passwords, tokens and PII from error bodies before they reach console or Sentry (rinafcode#792) - PermissionDeniedView: replaces the blank screen on a denied permission with an explanation and a route into system settings (rinafcode#793) - safeLog: guards logger calls so a throwing logger can never unwind the interceptor and lose the original error (rinafcode#794) - useAsyncEffectState: captures rejections from async effects instead of discarding them with the void operator (rinafcode#795)
|
@benzeneCLI Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four small, self-contained modules, one per issue. No existing files are modified, so this merges cleanly alongside the other open PRs.
What's included
src/utils/sanitizeErrorResponse.tspassword/token/secret/card/cvv/ssn/authorizationfrom error bodies before they reach console or Sentry. Depth-capped so a cyclic body cannot hang the logger.src/components/common/PermissionDeniedView.tsxsrc/utils/safeLog.tssrc/hooks/useAsyncEffectState.tsvoid, exposing{ error, loading }and skipping state updates after unmount.Notes
Closes #792
Closes #793
Closes #794
Closes #795