fix: narrow error types and give failures specific, typed handling - #898
Open
michaelsimeon001 wants to merge 1 commit into
Open
Conversation
Adds four small, self-contained modules: - toError: narrows unknown caught values to a real Error so reading .message in a catch block cannot throw a second time (rinafcode#796) - capabilityDegradation: applies failed capability checks to the degradation store so unusable features are actually disabled (rinafcode#797) - loginErrorMessages: maps each login failure to its own actionable message instead of one generic "Login failed" (rinafcode#798) - socketEvents: discriminated union for socket payloads, replacing Record<string, any> with compile-time checked event types (rinafcode#799)
|
@michaelsimeon001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four small, self-contained modules, one per issue. No existing files are modified, so this merges cleanly alongside the other open PRs.
What's included
src/utils/toError.tsError(preserving the original ascause) so reading.messagein a catch block cannot throw a second time and mask the original failure.src/services/capabilityDegradation.tssrc/utils/loginErrorMessages.tssrc/types/socketEvents.tsSocketEventunion replacingRecord<string, any>, plus anisSocketEventnarrowing guard.Notes
Closes #796
Closes #797
Closes #798
Closes #799