fix(store): validate courseProgressStore updates with type guard - #899
Merged
RUKAYAT-CODER merged 4 commits intoJul 28, 2026
Merged
Conversation
|
@Nacho1499 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #808
Summary:
Implemented runtime validation and narrowing for
lessonDataupdates incourseProgressStore.tsto prevent incomplete or invalid state transitions:isValidLessonProgresstype guard to verify requiredLessonProgressfields (lessonId,completed,lastPosition,timeSpent,completedAt).InvalidLessonProgressErrorwhenever incompletelessonDatais supplied before spreading candidate progress into the store.tsconfig.jsontest exclusion boundaries and added unit tests incourseProgressStore.test.tscovering type guard logic, invalid state rejection, and store state immutability on thrown errors.Type of Change:
[x] Bug fix (non-breaking change which fixes an issue)
Testing Done:
[x] Unit Tests
[x] Manual Verification (e.g., iOS/Android UI checks)
Security Considerations:
[x] Are all user inputs validated?
Checklist:
[x] I have read the CONTRIBUTING guide.
[x] My code follows the style guidelines of this project.
[x] I have updated the documentation accordingly.