Skip to content

fix: add validated platform helper to prevent receipt validation bypass #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RUKAYAT-CODER merged 1 commit into from
Jul 29, 2026
Merged

fix: add validated platform helper to prevent receipt validation bypass #901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/services/mobilePayments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,7 @@ class MobilePaymentsService {

store.setReceiptValidationPending(true);
try {
// SAFE: Explicit check for platform type instead of assertion
const platform = Platform.OS === 'ios' || Platform.OS === 'android' ? Platform.OS : 'ios';
const platform = this._getPlatform();

const result = await this.validateReceipt(receipt, platform, purchase.productId);

Expand Down Expand Up @@ -288,7 +287,7 @@ class MobilePaymentsService {
expiresAt: new Date(
Date.now() + (plan.period === 'monthly' ? 30 : 365) * 24 * 60 * 60 * 1000
).toISOString(),
platform: Platform.OS as 'ios' | 'android',
platform: this._getPlatform(),
};

await this._savePurchaseRecord(record);
Expand Down Expand Up @@ -319,7 +318,7 @@ class MobilePaymentsService {
type: 'one_time',
status: 'completed',
purchasedAt: new Date().toISOString(),
platform: Platform.OS as 'ios' | 'android',
platform: this._getPlatform(),
};

await this._savePurchaseRecord(record);
Expand Down Expand Up @@ -347,7 +346,7 @@ class MobilePaymentsService {
if (receipt) {
const result = await this.validateReceipt(
receipt,
Platform.OS as 'ios' | 'android',
this._getPlatform(),
purchase.productId
);
if (result.valid) {
Expand All @@ -364,7 +363,7 @@ class MobilePaymentsService {
purchasedAt: purchase.transactionDate
? new Date(purchase.transactionDate).toISOString()
: new Date().toISOString(),
platform: Platform.OS as 'ios' | 'android',
platform: this._getPlatform(),
receiptData: receipt,
});
await IAP.finishTransaction({ purchase, isConsumable: false });
Expand Down Expand Up @@ -494,6 +493,14 @@ class MobilePaymentsService {

// ─── Private helpers ────────────────────────────────────────────────────────

private _getPlatform(): 'ios' | 'android' {
if (Platform.OS === 'ios') return 'ios';
if (Platform.OS === 'android') return 'android';
throw new Error(
`Unsupported platform: ${Platform.OS}. In-app purchases require iOS or Android.`
);
}

private _throwIfDeviceCompromised(): void {
if (useDeviceStore.getState().isDeviceCompromised) {
throw new Error(
Expand Down
Loading