feat(agentos): redesigned dashboard inspector on the TS actor runtime#1780
Open
NicholasKissel wants to merge 4 commits into
Open
feat(agentos): redesigned dashboard inspector on the TS actor runtime#1780NicholasKissel wants to merge 4 commits into
NicholasKissel wants to merge 4 commits into
Conversation
|
🚅 Deployed to the agentos-pr-1780 environment in agentos
🚅 Environment agentos-pr-1780 in rivet-frontend has no services deployed. |
jog1t
reviewed
Jul 24, 2026
| const backfillRows = backfill.data; | ||
| useEffect(() => { | ||
| if (!backfillRows || backfillRows.length === 0) return; | ||
| setCards((prev) => { |
Collaborator
There was a problem hiding this comment.
To fix after merge: never* use setstate in useeffect, need to add this to Claude.md
Comment on lines
+158
to
+166
| const imageUrl = useMemo(() => { | ||
| if (!data?.bytes || data.text !== null || !IMAGE_EXTENSIONS.test(data.path)) return null; | ||
| return URL.createObjectURL(new Blob([data.bytes as BlobPart])); | ||
| }, [data]); | ||
| useEffect(() => { | ||
| return () => { | ||
| if (imageUrl) URL.revokeObjectURL(imageUrl); | ||
| }; | ||
| }, [imageUrl]); |
Collaborator
There was a problem hiding this comment.
That's should be in self-contained hook
Comment on lines
+439
to
+452
| const createFolder = async () => { | ||
| const name = newFolderDraft?.trim(); | ||
| if (!name) { | ||
| setNewFolderDraft(null); | ||
| return; | ||
| } | ||
| setTreeError(null); | ||
| try { | ||
| await agentOsSource.mkdir(name.startsWith("/") ? name : joinRoot(currentDir, name)); | ||
| setNewFolderDraft(null); | ||
| await refreshTree(); | ||
| } catch (error) { | ||
| setTreeError(error); | ||
| } |
Collaborator
There was a problem hiding this comment.
A lot of setstate in one place, useReducer perhaps would be better
Comment on lines
+151
to
+152
| setBusy(true); | ||
| setError(null); |
Collaborator
There was a problem hiding this comment.
useMutstion will solve this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
healthaction (post-mortem limit-warning and agent-exit buffers that survive VM sleep, never boots the VM) as an actor extra alongside the preview-URL actionsinspectorconfig so the dashboard serves them without extra setuplistSessionswaiting-state backfill plussessionEventpermission entries); responses render each request's own ACP optionsassets/gitignore so the inspector SVG sources stay trackedSupersedes #1752, rebuilt on the TS actor runtime without the terminal tab.