fix: resolve per-session config caching issue across plugins#38
Open
eabdalmufid wants to merge 1 commit into
Open
fix: resolve per-session config caching issue across plugins#38eabdalmufid wants to merge 1 commit into
eabdalmufid wants to merge 1 commit into
Conversation
- Refactored faq-bot, after-hours, and chat-flow to parse configuration dynamically inside message hooks. - Replaced global config caching with dynamic liveCfg resolution via ctx.config. - Implemented consistent error handling to gracefully skip and warn on invalid configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where
faq-bot,after-hours, andchat-flowplugins incorrectly cached their configuration statically at activation (onEnable/onConfigChange).This static caching caused them to ignore dynamic per-session overrides (such as different rules or away messages for different WhatsApp numbers) managed by the OpenWA engine.
Changes Made
onMessagehooks infaq-bot,after-hours, andchat-flow.this.configusage with a dynamicparseConfig(ctx.config)resolution per event, aligning them with the established pattern inhttp-action.ctx.logger.warnand skips processing instead of falling back unexpectedly.dist/index.jsartifacts for all affected plugins.Testing